pikers
/
piker
4
1
Fork 0
Code Issues 11 Pull Requests 12 Packages Projects Releases Wiki Activity

stop_is_oec: expect trio.EndOfChannel as graceful stream shutdown #51

Closed
goodboy wants to merge 0 commits from main into stop_is_eoc
pull from: main
merge into: pikers:stop_is_eoc
Conversation 1 Commits - Files Changed -
goodboy commented 2026-01-01 19:41:09 +00:00
Owner

Replacement for #37 due to typo of eoc in orig branch name..

Copying descr content form that PR below..

This should likely be synced with tractor’s new typed-IPC-msging either via dev branch or (ideally) a release!

Change .data._sampling broadcast error handling to include trio.EndOfChannel in the Sampler.bcast_errors: set since a tractor.MsgStream termination msg (Stop) now instead translates to that raised in task.

The main purpose here is to avoid crashing the sampler broadcast task in such graceful peer-disconnect conditions.

Replacement for #37 due to typo of eoc in orig branch name.. Copying descr content form that PR below.. --- This should likely be synced with `tractor`'s new [typed-IPC-msging](https://pikers.dev/goodboy/tractor/pulls/7) either via dev branch or (ideally) a release! --- Change `.data._sampling` broadcast error handling to include `trio.EndOfChannel` in the `Sampler.bcast_errors: set` since a `tractor.MsgStream` termination msg (`Stop`) now instead translates to that raised in task. The main purpose here is to avoid crashing the sampler broadcast task in such graceful peer-disconnect conditions.
goodboy commented 2026-01-01 19:42:59 +00:00
Poster
Owner

Lol wow, from/into branches backward.. #52 is what this was meant to be..

Lol wow, from/into branches backward.. #52 is what this was meant to be..
goodboy closed this pull request 2026-01-01 19:42:59 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: pikers/piker#51
There is no content yet.
Delete Branch "main"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?