Just use platformdirs under our config.get_app_dir()?? #81

New Issue

goodboy · 2026-03-06T15:40:29Z

goodboy commented

2026-03-06 15:40:29 +00:00

I adopted it inside tractor for the macos support coming in,

And obvi we have macos support thus landing hereabouts,

#78

Deats of the current impl

we’re delegating to a copy of click’s internal fn,

https://github.com/pallets/click/blob/main/src/click/utils.py#L449

which we extended for our needs,

https://www.pikers.dev/pikers/piker/src/branch/main/piker/config.py#L44

BUT i’m pretty sure most of the meat of that fn’s body is now supported by platformdirs’ API no?

https://github.com/tox-dev/platformdirs

It’d be sure nice if someone could try replacing the internals with calls to it and ensure the test suite is all good (xplatform ofc!).

🙏

I adopted it inside `tractor` for the macos support coming in, - https://github.com/goodboy/tractor/pull/406 - https://github.com/goodboy/tractor/pull/342 And obvi we have macos support thus landing hereabouts, - https://pikers.dev/pikers/piker/pulls/78 --- ### Deats of the current impl we're delegating to a copy of `click`'s internal fn, - https://github.com/pallets/click/blob/main/src/click/utils.py#L449 which we extended for our needs, - https://www.pikers.dev/pikers/piker/src/branch/main/piker/config.py#L44 BUT i'm pretty sure most of the meat of that fn's body is now supported by `platformdirs`' API no? - https://github.com/tox-dev/platformdirs It'd be sure nice if someone could try replacing the internals with calls to it and ensure the test suite is all good (xplatform ofc!). 🙏

Sign in to join this conversation.

No Label

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: pikers/piker#81

Just use platformdirs under our config.get_app_dir()?? #81

Deats of the current impl

Just use `platformdirs` under our `config.get_app_dir()`?? #81