Add holiday-gap detection via `exchange_calendars`

Integrate `exchange_calendars` lib to detect market holidays in
gap-checking logic via new `.ib.venues.has_holiday()` helper!

The `.ib.venues` impl deats,
- add  a new `has_holiday()` using `xcals.get_calendar()` and friends
  for sanity checking a venue's holiday closure-gaps.
  * final holiday detection-check is basically,
   `(cash_gap := (next_open - prev_close)) > period`
- include `time_step_s` param to `is_venue_closure()` for boundary
  tolerance checks.
  * let's us expand closure-time checks to include `+/-time_step_s`
    "off-by-one-`timeframe`-sample" edge case ranges.
- add real docstring to `has_weekend()`.

In `.ib.api` refine usage for ^ changes,
- move `is_venue_open()` call + tz-convert outside gap check
- use a walrus to capture `has_closure_gap` from `is_venue_closure()`
- add a `not has_closure_gap` condition to the
  mismatched-duration/short-frame warning block to avoid needless warns.
- keep duration-based "short-frame" log as `.error()` but toss in a bp
  so (somone can) umask to figure out wtf is going on..
  * we should **never** really hit this path unless there's a valid bug
    or data issue with IB/GFIS!
  * keep recursion path masked-out just leave a `breakpoint()` for now.

Also some logger updates,
- import `get_logger()` from top-level `piker.log` vs `.ib._util` which
  was always kinda wrong..
- change `NonShittyIB._logger` to use `__name__` vs literal.

(this commit msg was generated in some part by [`claude-code`][claude-code-gh])
[claude-code-gh]: https://github.com/anthropics/claude-code

piker/accounting/__init__.py

@@ -19,10 +19,8 @@
 for tendiez.
 
 '''
-from piker.log import (
-    get_console_log,
-    get_logger,
-)
+from ..log import get_logger
+
 from .calc import (
     iter_by_dt,
 )
@@ -53,17 +51,7 @@ from ._allocate import (
 
 
 log = get_logger(__name__)
-# ?TODO, enable console on import
-# [ ] necessary? or `open_brokerd_dialog()` doing it is sufficient?
-#
-# bc might as well enable whenev imported by
-# other sub-sys code (namely `.clearing`).
-get_console_log(
-    level='warning',
-    name=__name__,
-)
 
-# TODO, the `as <samename>` style?
 __all__ = [
     'Account',
     'Allocator',

piker/accounting/_pos.py

@@ -60,16 +60,12 @@ from ..clearing._messages import (
     BrokerdPosition,
 )
 from piker.types import Struct
-from piker.log import (
-    get_logger,
-)
+from piker.log import get_logger
 
 if TYPE_CHECKING:
     from piker.data._symcache import SymbologyCache
 
-log = get_logger(
-    name=__name__,
-)
+log = get_logger(__name__)
 
 
 class Position(Struct):

piker/accounting/cli.py

@@ -21,6 +21,7 @@ CLI front end for trades ledger and position tracking management.
 from __future__ import annotations
 from pprint import pformat
 
+
 from rich.console import Console
 from rich.markdown import Markdown
 import polars as pl
@@ -28,10 +29,7 @@ import tractor
 import trio
 import typer
 
-from piker.log import (
-    get_console_log,
-    get_logger,
-)
+from ..log import get_logger
 from ..service import (
     open_piker_runtime,
 )
@@ -47,7 +45,6 @@ from .calc import (
     open_ledger_dfs,
 )
 
-log = get_logger(name=__name__)
 
 ledger = typer.Typer()
 
@@ -82,10 +79,7 @@ def sync(
         "-l",
     ),
 ):
-    log = get_console_log(
-        level=loglevel,
-        name=__name__,
-    )
+    log = get_logger(loglevel)
     console = Console()
 
     pair: tuple[str, str]

piker/brokers/__init__.py

@@ -25,16 +25,15 @@ from types import ModuleType
 
 from tractor.trionics import maybe_open_context
 
-from piker.log import (
-    get_logger,
-)
 from ._util import (
+    log,
     BrokerError,
     SymbolNotFound,
     NoData,
     DataUnavailable,
     DataThrottle,
     resproc,
+    get_logger,
 )
 
 __all__: list[str] = [
@@ -44,6 +43,7 @@ __all__: list[str] = [
     'DataUnavailable',
     'DataThrottle',
     'resproc',
+    'get_logger',
 ]
 
 __brokers__: list[str] = [
@@ -65,10 +65,6 @@ __brokers__: list[str] = [
     # bitso
 ]
 
-log = get_logger(
-    name=__name__,
-)
-
 
 def get_brokermod(brokername: str) -> ModuleType:
     '''

piker/brokers/_daemon.py

@@ -33,18 +33,12 @@ import exceptiongroup as eg
 import tractor
 import trio
 
-from piker.log import (
-    get_logger,
-    get_console_log,
-)
 from . import _util
 from . import get_brokermod
 
 if TYPE_CHECKING:
     from ..data import _FeedsBus
 
-log = get_logger(name=__name__)
-
 # `brokerd` enabled modules
 # TODO: move this def to the `.data` subpkg..
 # NOTE: keeping this list as small as possible is part of our caps-sec
@@ -78,14 +72,13 @@ async def _setup_persistent_brokerd(
     # since all hosted daemon tasks will reference this same
     # log instance's (actor local) state and thus don't require
     # any further (level) configuration on their own B)
-    actor: tractor.Actor = tractor.current_actor()
-    tll: str = actor.loglevel
-    log = get_console_log(
-        level=loglevel or tll,
+    log = _util.get_console_log(
+        loglevel or tractor.current_actor().loglevel,
         name=f'{_util.subsys}.{brokername}',
-        with_tractor_log=bool(tll),
     )
-    assert log.name == _util.subsys
+
+    # set global for this actor to this new process-wide instance B)
+    _util.log = log
 
     # further, set the log level on any broker broker specific
     # logger instance.
@@ -104,7 +97,7 @@ async def _setup_persistent_brokerd(
     # NOTE: see ep invocation details inside `.data.feed`.
     try:
         async with (
-            # tractor.trionics.collapse_eg(),
+            tractor.trionics.collapse_eg(),
             trio.open_nursery() as service_nursery
         ):
             bus: _FeedsBus = feed.get_feed_bus(
@@ -200,6 +193,7 @@ def broker_init(
 
 
 async def spawn_brokerd(
+
     brokername: str,
     loglevel: str | None = None,
 
@@ -207,10 +201,8 @@ async def spawn_brokerd(
 
 ) -> bool:
 
-    log.info(
-        f'Spawning broker-daemon,\n'
-        f'backend: {brokername!r}'
-    )
+    from piker.service._util import log  # use service mngr log
+    log.info(f'Spawning {brokername} broker daemon')
 
     (
         brokermode,
@@ -272,11 +264,6 @@ async def maybe_spawn_brokerd(
     '''
     from piker.service import maybe_spawn_daemon
 
-    # if (
-    #     loglevel != 'info'
-    # ):
-    #     await tractor.pause()
-
     async with maybe_spawn_daemon(
 
         f'brokerd.{brokername}',

piker/brokers/_util.py

@@ -19,13 +19,15 @@ Handy cross-broker utils.
 
 """
 from __future__ import annotations
-# from functools import partial
+from functools import partial
 
 import json
 import httpx
 import logging
 
-from piker.log import (
+from ..log import (
+    get_logger,
+    get_console_log,
     colorize_json,
 )
 subsys: str = 'piker.brokers'
@@ -33,22 +35,12 @@ subsys: str = 'piker.brokers'
 # NOTE: level should be reset by any actor that is spawned
 # as well as given a (more) explicit name/key such
 # as `piker.brokers.binance` matching the subpkg.
-# log = get_logger(subsys)
+log = get_logger(subsys)
 
-# ?TODO?? we could use this approach, but we need to be able
-# to pass multiple `name=` values so for example we can include the
-# emissions in `.accounting._pos` and others!
-# [ ] maybe we could do the `log = get_logger()` above,
-# then cycle through the list of subsys mods we depend on
-# and then get all their loggers and pass them to
-# `get_console_log(logger=)`??
-# [ ] OR just write THIS `get_console_log()` as a hook which does
-# that based on who calls it?.. i dunno
-#
-# get_console_log = partial(
-#     get_console_log,
-#     name=subsys,
-# )
+get_console_log = partial(
+    get_console_log,
+    name=subsys,
+)
 
 
 class BrokerError(Exception):

piker/brokers/binance/broker.py

@@ -37,9 +37,8 @@ import trio
 from piker.accounting import (
     Asset,
 )
-from piker.log import (
+from piker.brokers._util import (
     get_logger,
-    get_console_log,
 )
 from piker.data._web_bs import (
     open_autorecon_ws,
@@ -70,9 +69,7 @@ from .venues import (
 )
 from .api import Client
 
-log = get_logger(
-    name=__name__,
-)
+log = get_logger('piker.brokers.binance')
 
 
 # Fee schedule template, mostly for paper engine fees modelling.
@@ -248,16 +245,9 @@ async def handle_order_requests(
 @tractor.context
 async def open_trade_dialog(
     ctx: tractor.Context,
-    loglevel: str = 'warning',
 
 ) -> AsyncIterator[dict[str, Any]]:
 
-    # enable piker.clearing console log for *this* `brokerd` subactor
-    get_console_log(
-        level=loglevel,
-        name=__name__,
-    )
-
     # TODO: how do we set this from the EMS such that
     # positions are loaded from the correct venue on the user
     # stream at startup? (that is in an attempt to support both

piker/brokers/binance/feed.py

@@ -64,9 +64,9 @@ from piker.data._web_bs import (
     open_autorecon_ws,
     NoBsWs,
 )
-from piker.log import get_logger
 from piker.brokers._util import (
     DataUnavailable,
+    get_logger,
 )
 
 from .api import (
@@ -78,7 +78,7 @@ from .venues import (
     get_api_eps,
 )
 
-log = get_logger(name=__name__)
+log = get_logger('piker.brokers.binance')
 
 
 class L1(Struct):

piker/brokers/cli.py

@@ -27,12 +27,14 @@ import click
 import trio
 import tractor
 
-from piker.cli import cli
-from piker import watchlists as wl
-from piker.log import (
+from ..cli import cli
+from .. import watchlists as wl
+from ..log import (
     colorize_json,
+)
+from ._util import (
+    log,
     get_console_log,
-    get_logger,
 )
 from ..service import (
     maybe_spawn_brokerd,
@@ -43,15 +45,12 @@ from ..brokers import (
     get_brokermod,
     data,
 )
-
-log = get_logger(
-    name=__name__,
-)
-
 DEFAULT_BROKER = 'binance'
+
 _config_dir = click.get_app_dir('piker')
 _watchlists_data_path = os.path.join(_config_dir, 'watchlists.json')
 
+
 OK = '\033[92m'
 WARNING = '\033[93m'
 FAIL = '\033[91m'
@@ -346,10 +345,7 @@ def contracts(ctx, loglevel, broker, symbol, ids):
 
     '''
     brokermod = get_brokermod(broker)
-    get_console_log(
-        level=loglevel,
-        name=__name__,
-    )
+    get_console_log(loglevel)
 
     contracts = trio.run(partial(core.contracts, brokermod, symbol))
     if not ids:
@@ -481,12 +477,11 @@ def search(
     # the `piker --pdb` XD ..
     # -[ ] pull from the parent click ctx's values..dumdum
     # assert pdb
-    loglevel: str = config['loglevel']
 
     # define tractor entrypoint
     async def main(func):
         async with maybe_open_pikerd(
-            loglevel=loglevel,
+            loglevel=config['loglevel'],
             debug_mode=pdb,
         ):
             return await func()
@@ -499,7 +494,6 @@ def search(
                 core.symbol_search,
                 brokermods,
                 pattern,
-                loglevel=loglevel,
             ),
         )
 

piker/brokers/core.py

@@ -28,14 +28,12 @@ from typing import (
 
 import trio
 
-from piker.log import get_logger
+from ._util import log
 from . import get_brokermod
 from ..service import maybe_spawn_brokerd
 from . import open_cached_client
 from ..accounting import MktPair
 
-log = get_logger(name=__name__)
-
 
 async def api(brokername: str, methname: str, **kwargs) -> dict:
     '''
@@ -149,7 +147,6 @@ async def search_w_brokerd(
 async def symbol_search(
     brokermods: list[ModuleType],
     pattern: str,
-    loglevel: str = 'warning',
     **kwargs,
 
 ) -> dict[str, dict[str, dict[str, Any]]]:
@@ -179,7 +176,6 @@ async def symbol_search(
                 '_infect_asyncio',
                 False,
             ),
-            loglevel=loglevel
         ) as portal:
 
             results.append((

piker/brokers/data.py

@@ -41,15 +41,12 @@ import tractor
 from tractor.experimental import msgpub
 from async_generator import asynccontextmanager
 
-from piker.log import(
-    get_logger,
+from ._util import (
+    log,
     get_console_log,
 )
 from . import get_brokermod
 
-log = get_logger(
-    name='piker.brokers.binance',
-)
 
 async def wait_for_network(
     net_func: Callable,
@@ -246,10 +243,7 @@ async def start_quote_stream(
 
     '''
     # XXX: why do we need this again?
-    get_console_log(
-        level=tractor.current_actor().loglevel,
-        name=__name__,
-    )
+    get_console_log(tractor.current_actor().loglevel)
 
     # pull global vars from local actor
     symbols = list(symbols)

piker/brokers/ib/_util.py

@@ -34,13 +34,13 @@ import subprocess
 
 import tractor
 
-from piker.log import get_logger
+from piker.brokers._util import get_logger
 
 if TYPE_CHECKING:
     from .api import Client
     import i3ipc
 
-log = get_logger(name=__name__)
+log = get_logger('piker.brokers.ib')
 
 _reset_tech: Literal[
     'vnc',

piker/brokers/ib/broker.py

@@ -50,10 +50,6 @@ from ib_insync.objects import (
 )
 
 from piker import config
-from piker.log import (
-    get_logger,
-    get_console_log,
-)
 from piker.types import Struct
 from piker.accounting import (
     Position,
@@ -81,6 +77,7 @@ from piker.clearing._messages import (
     BrokerdFill,
     BrokerdError,
 )
+from ._util import log
 from .api import (
     _accounts2clients,
     get_config,
@@ -98,10 +95,6 @@ from .ledger import (
     update_ledger_from_api_trades,
 )
 
-log = get_logger(
-    name=__name__,
-)
-
 
 def pack_position(
     pos: IbPosition,
@@ -543,15 +536,9 @@ class IbAcnt(Struct):
 @tractor.context
 async def open_trade_dialog(
     ctx: tractor.Context,
-    loglevel: str = 'warning',
 
 ) -> AsyncIterator[dict[str, Any]]:
 
-    get_console_log(
-        level=loglevel,
-        name=__name__,
-    )
-
     # task local msg dialog tracking
     flows = OrderDialogs()
     accounts_def = config.load_accounts(['ib'])

piker/brokers/ib/feed.py

@@ -56,11 +56,11 @@ from piker.brokers._util import (
     NoData,
     DataUnavailable,
 )
-from piker.log import get_logger
 from .api import (
     # _adhoc_futes_set,
     Client,
     con2fqme,
+    log,
     load_aio_clients,
     MethodProxy,
     open_client_proxies,
@@ -78,9 +78,6 @@ from .symbols import get_mkt_info
 if TYPE_CHECKING:
     from trio._core._run import Task
 
-log = get_logger(
-    name=__name__,
-)
 
 # XXX NOTE: See available types table docs:
 # https://interactivebrokers.github.io/tws-api/tick_types.html

piker/brokers/ib/ledger.py

@@ -44,7 +44,6 @@ from ib_insync import (
     CommissionReport,
 )
 
-from piker.log import get_logger
 from piker.types import Struct
 from piker.data import (
     SymbologyCache,
@@ -58,6 +57,7 @@ from piker.accounting import (
     iter_by_dt,
 )
 from ._flex_reports import parse_flex_dt
+from ._util import log
 
 if TYPE_CHECKING:
     from .api import (
@@ -65,9 +65,6 @@ if TYPE_CHECKING:
         MethodProxy,
     )
 
-log = get_logger(
-    name=__name__,
-)
 
 tx_sort: Callable = partial(
     iter_by_dt,

piker/brokers/ib/symbols.py

@@ -42,7 +42,10 @@ from piker.accounting import (
 from piker._cacheables import (
     async_lifo_cache,
 )
-from piker.log import get_logger
+
+from ._util import (
+    log,
+)
 
 if TYPE_CHECKING:
     from .api import (
@@ -50,10 +53,6 @@ if TYPE_CHECKING:
         Client,
     )
 
-log = get_logger(
-    name=__name__,
-)
-
 _futes_venues = (
     'GLOBEX',
     'NYMEX',

piker/brokers/kraken/broker.py

@@ -62,12 +62,9 @@ from piker.clearing._messages import (
 from piker.brokers import (
     open_cached_client,
 )
-from piker.log import (
-    get_console_log,
-    get_logger,
-)
 from piker.data import open_symcache
 from .api import (
+    log,
     Client,
     BrokerError,
 )
@@ -81,8 +78,6 @@ from .ledger import (
     verify_balances,
 )
 
-log = get_logger(name=__name__)
-
 MsgUnion = Union[
     BrokerdCancel,
     BrokerdError,
@@ -436,15 +431,9 @@ def trades2pps(
 @tractor.context
 async def open_trade_dialog(
     ctx: tractor.Context,
-    loglevel: str = 'warning',
 
 ) -> AsyncIterator[dict[str, Any]]:
 
-    get_console_log(
-        level=loglevel,
-        name=__name__,
-    )
-
     async with (
         # TODO: maybe bind these together and deliver
         # a tuple from `.open_cached_client()`?

piker/brokers/questrade.py

@@ -50,19 +50,13 @@ from . import open_cached_client
 from piker._cacheables import async_lifo_cache
 from .. import config
 from ._util import resproc, BrokerError, SymbolNotFound
-from piker.log import (
+from ..log import (
     colorize_json,
+)
+from ._util import (
+    log,
     get_console_log,
 )
-from piker.log import (
-    get_logger,
-)
-
-
-log = get_logger(
-    name=__name__,
-)
-
 
 _use_practice_account = False
 _refresh_token_ep = 'https://{}login.questrade.com/oauth2/'
@@ -1211,10 +1205,7 @@ async def stream_quotes(
     # feed_type: str = 'stock',
 ) -> AsyncGenerator[str, Dict[str, Any]]:
     # XXX: required to propagate ``tractor`` loglevel to piker logging
-    get_console_log(
-        level=loglevel,
-        name=__name__,
-    )
+    get_console_log(loglevel)
 
     async with open_cached_client('questrade') as client:
         if feed_type == 'stock':

piker/brokers/robinhood.py

@@ -30,16 +30,9 @@ import asks
 from ._util import (
     resproc,
     BrokerError,
+    log,
 )
-from piker.calc import percent_change
-from piker.log import (
-    get_logger,
-)
-
-log = get_logger(
-    name=__name__,
-)
-
+from ..calc import percent_change
 
 _service_ep = 'https://api.robinhood.com'
 

piker/clearing/_client.py

@@ -215,7 +215,7 @@ async def relay_orders_from_sync_code(
 async def open_ems(
     fqme: str,
     mode: str = 'live',
-    loglevel: str = 'warning',
+    loglevel: str = 'error',
 
 ) -> tuple[
     OrderClient,  # client

piker/clearing/_ems.py

@@ -47,7 +47,6 @@ from tractor import trionics
 from ._util import (
     log,  # sub-sys logger
     get_console_log,
-    subsys,
 )
 from ..accounting._mktinfo import (
     unpack_fqme,
@@ -352,21 +351,9 @@ async def open_brokerd_dialog(
     broker backend, configuration, or client code usage.
 
     '''
-    get_console_log(
-        level=loglevel,
-        name='clearing',
-    )
-    # enable `.accounting` console since normally used by
-    # each `brokerd`.
-    get_console_log(
-        level=loglevel,
-        name='piker.accounting',
-    )
     broker: str = brokermod.name
 
-    def mk_paper_ep(
-        loglevel: str,
-    ):
+    def mk_paper_ep():
         from . import _paper_engine as paper_mod
 
         nonlocal brokermod, exec_mode
@@ -418,21 +405,17 @@ async def open_brokerd_dialog(
 
     if (
         trades_endpoint is not None
-        or
-        exec_mode != 'paper'
+        or exec_mode != 'paper'
     ):
         # open live brokerd trades endpoint
         open_trades_endpoint = portal.open_context(
             trades_endpoint,
-            loglevel=loglevel,
         )
 
     @acm
     async def maybe_open_paper_ep():
         if exec_mode == 'paper':
-            async with mk_paper_ep(
-                loglevel=loglevel,
-            ) as msg:
+            async with mk_paper_ep() as msg:
                 yield msg
                 return
 
@@ -443,9 +426,7 @@ async def open_brokerd_dialog(
             # runtime indication that the backend can't support live
             # order ctrl yet, so boot the paperboi B0
             if first == 'paper':
-                async with mk_paper_ep(
-                    loglevel=loglevel,
-                ) as msg:
+                async with mk_paper_ep() as msg:
                     yield msg
                     return
             else:
@@ -748,7 +729,6 @@ class Router(Struct):
             except (
                 trio.ClosedResourceError,
                 trio.BrokenResourceError,
-                tractor.TransportClosed,
             ):
                 to_remove.add(client_stream)
                 log.warning(
@@ -785,11 +765,7 @@ async def _setup_persistent_emsd(
 ) -> None:
 
     if loglevel:
-        _log = get_console_log(
-            level=loglevel,
-            name=subsys,
-        )
-        assert _log.name == 'piker.clearing'
+        get_console_log(loglevel)
 
     global _router
 
@@ -1723,5 +1699,5 @@ async def _emsd_main(
                     if not client_streams:
                         log.warning(
                             f'Order dialog is not being monitored:\n'
-                            f'{oid!r} <-> {client_stream.chan.aid.reprol()}\n'
+                            f'{oid} ->\n{client_stream._ctx.chan.uid}'
                         )

piker/clearing/_paper_engine.py

@@ -59,9 +59,9 @@ from piker.data import (
     open_symcache,
 )
 from piker.types import Struct
-from piker.log import (
+from ._util import (
+    log,  # sub-sys logger
     get_console_log,
-    get_logger,
 )
 from ._messages import (
     BrokerdCancel,
@@ -73,8 +73,6 @@ from ._messages import (
     BrokerdError,
 )
 
-log = get_logger(name=__name__)
-
 
 class PaperBoi(Struct):
     '''
@@ -552,6 +550,7 @@ _sells: defaultdict[
 
 @tractor.context
 async def open_trade_dialog(
+
     ctx: tractor.Context,
     broker: str,
     fqme: str | None = None,  # if empty, we only boot broker mode
@@ -559,11 +558,8 @@ async def open_trade_dialog(
 
 ) -> None:
 
-    # enable piker.clearing console log for *this* `brokerd` subactor
-    get_console_log(
-        level=loglevel,
-        name=__name__,
-    )
+    # enable piker.clearing console log for *this* subactor
+    get_console_log(loglevel)
 
     symcache: SymbologyCache
     async with open_symcache(get_brokermod(broker)) as symcache:

piker/clearing/_util.py

@@ -28,14 +28,12 @@ from ..log import (
 from piker.types import Struct
 subsys: str = 'piker.clearing'
 
-log = get_logger(
-    name='piker.clearing',
-)
+log = get_logger(subsys)
 
 # TODO, oof doesn't this ignore the `loglevel` then???
 get_console_log = partial(
     get_console_log,
-    name='clearing',
+    name=subsys,
 )
 
 

piker/cli/__init__.py

@@ -61,8 +61,7 @@ def load_trans_eps(
 
     if (
         network
-        and
-        not maddrs
+        and not maddrs
     ):
         # load network section and (attempt to) connect all endpoints
         # which are reachable B)
@@ -113,27 +112,31 @@ def load_trans_eps(
     default=None,
     help='Multiaddrs to bind or contact',
 )
+# @click.option(
+#     '--tsdb',
+#     is_flag=True,
+#     help='Enable local ``marketstore`` instance'
+# )
+# @click.option(
+#     '--es',
+#     is_flag=True,
+#     help='Enable local ``elasticsearch`` instance'
+# )
 def pikerd(
     maddr: list[str] | None,
     loglevel: str,
     tl: bool,
     pdb: bool,
+    # tsdb: bool,
+    # es: bool,
 ):
     '''
-    Start the "root service actor", `pikerd`, run it until
-    cancellation.
-
-    This "root daemon" operates as the top most service-mngr and
-    subsys-as-subactor supervisor, think of it as the "init proc" of
-    any of any `piker` application or daemon-process tree.
+    Spawn the piker broker-daemon.
 
     '''
     # from tractor.devx import maybe_open_crash_handler
     # with maybe_open_crash_handler(pdb=False):
-    log = get_console_log(
-        level=loglevel,
-        with_tractor_log=tl,
-    )
+    log = get_console_log(loglevel, name='cli')
 
     if pdb:
         log.warning((
@@ -234,14 +237,6 @@ def cli(
     regaddr: str,
 
 ) -> None:
-    '''
-    The "root" `piker`-cmd CLI endpoint.
-
-    NOTE, this def generally relies on and requires a sub-cmd to be
-    provided by the user, OW only a `--help` msg (listing said
-    subcmds) will be dumped to console.
-
-    '''
     if configdir is not None:
         assert os.path.isdir(configdir), f"`{configdir}` is not a valid path"
         config._override_config_dir(configdir)
@@ -300,50 +295,17 @@ def cli(
 @click.option('--tl', is_flag=True, help='Enable tractor logging')
 @click.argument('ports', nargs=-1, required=False)
 @click.pass_obj
-def services(
-    config,
-    tl: bool,
-    ports: list[int],
-):
-    '''
-    List all `piker` "service deamons" to the console in
-    a `json`-table which maps each actor's UID in the form,
+def services(config, tl, ports):
 
-    `{service_name}.{subservice_name}.{UUID}`
-
-    to its (primary) IPC server address.
-
-    (^TODO, should be its multiaddr form once we support it)
-
-    Note that by convention actors which operate as "headless"
-    processes (those without GUIs/graphics, and which generally
-    parent some noteworthy subsystem) are normally suffixed by
-    a "d" such as,
-
-    - pikerd: the root runtime supervisor
-    - brokerd: a broker-backend order ctl daemon
-    - emsd: the internal dark-clearing and order routing daemon
-    - datad: a data-provider-backend data feed daemon
-    - samplerd: the real-time data sampling and clock-syncing daemon
-
-    "Headed units" are normally just given an obvious app-like name
-    with subactors indexed by `.` such as,
-    - chart: the primary modal charting iface, a Qt app
-    - chart.fsp_0: a financial-sig-proc cascade instance which
-                   delivers graphics to a parent `chart` app.
-    - polars_boi: some (presumably) `polars` using console app.
-
-    '''
-    from piker.service import (
+    from ..service import (
         open_piker_runtime,
         _default_registry_port,
         _default_registry_host,
     )
 
-    # !TODO, mk this to work with UDS!
-    host: str = _default_registry_host
+    host = _default_registry_host
     if not ports:
-        ports: list[int] = [_default_registry_port]
+        ports = [_default_registry_port]
 
     addr = tractor._addr.wrap_address(
         addr=(host, ports[0])
@@ -354,11 +316,7 @@ def services(
         async with (
             open_piker_runtime(
                 name='service_query',
-                loglevel=(
-                    config['loglevel']
-                    if tl
-                    else None
-                ),
+                loglevel=config['loglevel'] if tl else None,
             ),
             tractor.get_registry(
                 addr=addr,
@@ -378,15 +336,7 @@ def services(
 
 
 def _load_clis() -> None:
-    '''
-    Dynamically load and register all subsys CLI endpoints (at call
-    time).
-
-    NOTE, obviously this is normally expected to be called at
-    `import` time and implicitly relies on our use of various
-    `click`/`typer` decorator APIs.
-
-    '''
+    # from ..service import elastic  # noqa
     from ..brokers import cli  # noqa
     from ..ui import cli  # noqa
     from ..watchlists import cli  # noqa
@@ -396,5 +346,5 @@ def _load_clis() -> None:
     from ..accounting import cli  # noqa
 
 
-# load all subsytem cli eps
+# load downstream cli modules
 _load_clis()

piker/data/_sampling.py

@@ -99,7 +99,6 @@ class Sampler:
         trio.BrokenResourceError,
         trio.ClosedResourceError,
         trio.EndOfChannel,
-        tractor.TransportClosed,
     )
 
     # holds all the ``tractor.Context`` remote subscriptions for
@@ -292,10 +291,9 @@ class Sampler:
 
                     except self.bcast_errors as err:
                         log.error(
-                            f'Connection dropped for IPC ctx due to,\n'
-                            f'{type(err)!r}\n'
-                            f'\n'
-                            f'{stream._ctx}'
+                            f'Connection dropped for IPC ctx\n'
+                            f'{stream._ctx}\n\n'
+                            f'Due to {type(err)}'
                         )
                         borked.add(stream)
                 else:
@@ -336,18 +334,10 @@ async def register_with_sampler(
 
     open_index_stream: bool = True,  # open a 2way stream for sample step msgs?
     sub_for_broadcasts: bool = True,  # sampler side to send step updates?
-    loglevel: str|None = None,
 
 ) -> set[int]:
 
-    get_console_log(
-        level=(
-            loglevel
-            or
-            tractor.current_actor().loglevel
-        ),
-        name=__name__,
-    )
+    get_console_log(tractor.current_actor().loglevel)
     incr_was_started: bool = False
 
     try:
@@ -484,7 +474,6 @@ async def spawn_samplerd(
                 register_with_sampler,
                 period_s=1,
                 sub_for_broadcasts=False,
-                loglevel=loglevel,
             )
             return True
 
@@ -493,6 +482,7 @@ async def spawn_samplerd(
 
 @acm
 async def maybe_open_samplerd(
+
     loglevel: str|None = None,
     **pikerd_kwargs,
 
@@ -521,10 +511,10 @@ async def open_sample_stream(
     shms_by_period: dict[float, dict]|None = None,
     open_index_stream: bool = True,
     sub_for_broadcasts: bool = True,
-    loglevel: str|None = None,
 
-    # cache_key: str|None = None,
-    # allow_new_sampler: bool = True,
+    cache_key: str|None = None,
+    allow_new_sampler: bool = True,
+
     ensure_is_active: bool = False,
 
 ) -> AsyncIterator[dict[str, float]]:
@@ -559,9 +549,7 @@ async def open_sample_stream(
         # XXX: this should be singleton on a host,
         # a lone broker-daemon per provider should be
         # created for all practical purposes
-        maybe_open_samplerd(
-            loglevel=loglevel,
-        ) as portal,
+        maybe_open_samplerd() as portal,
 
         portal.open_context(
             register_with_sampler,
@@ -570,7 +558,6 @@ async def open_sample_stream(
                 'shms_by_period': shms_by_period,
                 'open_index_stream': open_index_stream,
                 'sub_for_broadcasts': sub_for_broadcasts,
-                'loglevel': loglevel,
             },
         ) as (ctx, shm_periods)
     ):
@@ -766,7 +753,7 @@ async def sample_and_broadcast(
                                 log.warning(
                                     f'Feed OVERRUN {sub_key}'
                                     f'@{bus.brokername} -> \n'
-                                    f'feed @ {chan.aid.reprol()}\n'
+                                    f'feed @ {chan.uid}\n'
                                     f'throttle = {throttle} Hz'
                                 )
 

piker/data/_util.py

@@ -26,9 +26,7 @@ from ..log import (
 )
 subsys: str = 'piker.data'
 
-log = get_logger(
-    name=subsys,
-)
+log = get_logger(subsys)
 
 get_console_log = partial(
     get_console_log,

piker/data/_web_bs.py

@@ -31,7 +31,6 @@ from typing import (
     AsyncContextManager,
     AsyncGenerator,
     Iterable,
-    Type,
 )
 import json
 
@@ -68,7 +67,7 @@ class NoBsWs:
 
     '''
     # apparently we can QoS for all sorts of reasons..so catch em.
-    recon_errors: tuple[Type[Exception]] = (
+    recon_errors = (
         ConnectionClosed,
         DisconnectionTimeout,
         ConnectionRejected,
@@ -106,10 +105,7 @@ class NoBsWs:
     def connected(self) -> bool:
         return self._connected.is_set()
 
-    async def reset(
-        self,
-        timeout: float,
-    ) -> bool:
+    async def reset(self) -> None:
         '''
         Reset the underlying ws connection by cancelling
         the bg relay task and waiting for it to signal
@@ -118,31 +114,18 @@ class NoBsWs:
         '''
         self._connected = trio.Event()
         self._cs.cancel()
-        with trio.move_on_after(timeout) as cs:
         await self._connected.wait()
-            return True
-
-        assert cs.cancelled_caught
-        return False
 
     async def send_msg(
         self,
         data: Any,
-        timeout: float = 3,
     ) -> None:
         while True:
             try:
                 msg: Any = self._dumps(data)
                 return await self._ws.send_message(msg)
             except self.recon_errors:
-                with trio.CancelScope(shield=True):
-                    reconnected: bool = await self.reset(
-                        timeout=timeout,
-                    )
-                    if not reconnected:
-                        log.warning(
-                            'Failed to reconnect after {timeout!r}s ??'
-                        )
+                await self.reset()
 
     async def recv_msg(self) -> Any:
         msg: Any = await self._rx.receive()
@@ -208,9 +191,7 @@ async def _reconnect_forever(
                         f'{src_mod}\n'
                         f'{url} connection bail with:'
                     )
-                    with trio.CancelScope(shield=True):
                     await trio.sleep(0.5)
-
                     rent_cs.cancel()
 
                     # go back to reonnect loop in parent task
@@ -310,7 +291,6 @@ async def _reconnect_forever(
             log.exception(
                 'Reconnect-attempt failed ??\n'
             )
-            with trio.CancelScope(shield=True):
             await trio.sleep(0.2)  # throttle
             raise berr
 
@@ -371,7 +351,6 @@ async def open_autorecon_ws(
     rcv: trio.MemoryReceiveChannel
     snd, rcv = trio.open_memory_channel(616)
 
-    try:
     async with (
         tractor.trionics.collapse_eg(),
         trio.open_nursery() as tn
@@ -399,12 +378,6 @@ async def open_autorecon_ws(
         finally:
             tn.cancel_scope.cancel()
 
-    except NoBsWs.recon_errors as con_err:
-        log.warning(
-            f'Entire ws-channel disconnect due to,\n'
-            f'con_err: {con_err!r}\n'
-        )
-
 
 '''
 JSONRPC response-request style machinery for transparent multiplexing

piker/data/feed.py

@@ -62,6 +62,7 @@ from ._util import (
     log,
     get_console_log,
 )
+from .flows import Flume
 from .validate import (
     FeedInit,
     validate_backend,
@@ -76,7 +77,6 @@ from ._sampling import (
 )
 
 if TYPE_CHECKING:
-    from .flows import Flume
     from tractor._addr import Address
     from tractor.msg.types import Aid
 
@@ -239,6 +239,7 @@ async def allocate_persistent_feed(
 
     brokername: str,
     symstr: str,
+
     loglevel: str,
     start_stream: bool = True,
     init_timeout: float = 616,
@@ -347,14 +348,11 @@ async def allocate_persistent_feed(
         izero_rt,
         rt_shm,
     ) = await bus.nursery.start(
-        partial(
         manage_history,
-            mod=mod,
-            mkt=mkt,
-            some_data_ready=some_data_ready,
-            feed_is_live=feed_is_live,
-            loglevel=loglevel,
-        )
+        mod,
+        mkt,
+        some_data_ready,
+        feed_is_live,
     )
 
     # yield back control to starting nursery once we receive either
@@ -364,8 +362,6 @@ async def allocate_persistent_feed(
     )
     await some_data_ready.wait()
 
-    # XXX, avoid cycle; it imports this mod.
-    from .flows import Flume
     flume = Flume(
 
         # TODO: we have to use this for now since currently the
@@ -462,6 +458,7 @@ async def allocate_persistent_feed(
 
 @tractor.context
 async def open_feed_bus(
+
     ctx: tractor.Context,
     brokername: str,
     symbols: list[str],  # normally expected to the broker-specific fqme
@@ -482,16 +479,13 @@ async def open_feed_bus(
 
     '''
     if loglevel is None:
-        loglevel: str = tractor.current_actor().loglevel
+        loglevel = tractor.current_actor().loglevel
 
     # XXX: required to propagate ``tractor`` loglevel to piker
     # logging
     get_console_log(
-        level=(loglevel
-            or
-            tractor.current_actor().loglevel
-        ),
-        name=__name__,
+        loglevel
+        or tractor.current_actor().loglevel
     )
 
     # local state sanity checks
@@ -506,6 +500,7 @@ async def open_feed_bus(
     sub_registered = trio.Event()
 
     flumes: dict[str, Flume] = {}
+
     for symbol in symbols:
 
         # if no cached feed for this symbol has been created for this
@@ -689,7 +684,6 @@ class Feed(Struct):
     '''
     mods: dict[str, ModuleType] = {}
     portals: dict[ModuleType, tractor.Portal] = {}
-
     flumes: dict[
         str,  # FQME
         Flume,
@@ -819,11 +813,6 @@ async def maybe_open_feed(
     '''
     fqme = fqmes[0]
 
-    # if (
-    #     loglevel != 'info'
-    # ):
-    #     await tractor.pause()
-
     async with trionics.maybe_open_context(
         acm_func=open_feed,
         kwargs={
@@ -890,12 +879,9 @@ async def open_feed(
         providers.setdefault(mod, []).append(bs_fqme)
         feed.mods[mod.name] = mod
 
-    if (
-        loglevel != 'info'
-    ):
-        await tractor.pause()
     # one actor per brokerd for now
     brokerd_ctxs = []
+
     for brokermod, bfqmes in providers.items():
 
         # if no `brokerd` for this backend exists yet we spawn
@@ -965,8 +951,6 @@ async def open_feed(
 
         assert len(feed.mods) == len(feed.portals)
 
-        # XXX, avoid cycle; it imports this mod.
-        from .flows import Flume
         async with (
             trionics.gather_contexts(bus_ctxs) as ctxs,
         ):

piker/fsp/_engine.py

@@ -24,7 +24,6 @@ from functools import partial
 from typing import (
     AsyncIterator,
     Callable,
-    TYPE_CHECKING,
 )
 
 import numpy as np
@@ -34,12 +33,12 @@ import tractor
 from tractor.msg import NamespacePath
 
 from piker.types import Struct
-from ..log import (
-    get_logger,
-    get_console_log,
-)
+from ..log import get_logger, get_console_log
 from .. import data
-from ..data.flows import Flume
+from ..data.feed import (
+    Flume,
+    Feed,
+)
 from ..data._sharedmem import ShmArray
 from ..data._sampling import (
     _default_delay_s,
@@ -53,9 +52,6 @@ from ._api import (
 )
 from ..toolz import Profiler
 
-if TYPE_CHECKING:
-    from ..data.feed import Feed
-
 log = get_logger(__name__)
 
 
@@ -173,10 +169,8 @@ class Cascade(Struct):
         if not synced:
             fsp: Fsp = self.fsp
             log.warning(
-                f'***DESYNCED fsp***\n'
-                f'------------------\n'
-                f'ns-path: {fsp.ns_path!r}\n'
-                f'shm-token: {src_shm.token}\n'
+                '***DESYNCED FSP***\n'
+                f'{fsp.ns_path}@{src_shm.token}\n'
                 f'step_diff: {step_diff}\n'
                 f'len_diff: {len_diff}\n'
             )
@@ -404,6 +398,7 @@ async def connect_streams(
 
 @tractor.context
 async def cascade(
+
     ctx: tractor.Context,
 
     # data feed key
@@ -431,17 +426,7 @@ async def cascade(
     )
 
     if loglevel:
-        log = get_console_log(
-            loglevel,
-            name=__name__,
-        )
-        # XXX TODO!
-        # figure out why this writes a dict to,
-        # `tractor._state._runtime_vars['_root_mailbox']`
-        # XD .. wtf
-        # TODO, solve this as reported in,
-        # https://www.pikers.dev/pikers/piker/issues/70
-        # await tractor.pause()
+        get_console_log(loglevel)
 
     src: Flume = Flume.from_msg(src_flume_addr)
     dst: Flume = Flume.from_msg(
@@ -484,8 +469,7 @@ async def cascade(
     # open a data feed stream with requested broker
     feed: Feed
     async with data.feed.maybe_open_feed(
-        fqmes=[fqme],
-        loglevel=loglevel,
+        [fqme],
 
         # TODO throttle tick outputs from *this* daemon since
         # it'll emit tons of ticks due to the throttle only
@@ -583,8 +567,7 @@ async def cascade(
                     # on every step msg received from the global `samplerd`
                     # service.
                     async with open_sample_stream(
-                        period_s=float(delay_s),
-                        loglevel=loglevel,
+                        float(delay_s)
                     ) as istream:
 
                         profiler(f'{func_name}: sample stream up')

piker/log.py

@@ -37,84 +37,35 @@ _proj_name: str = 'piker'
 
 
 def get_logger(
-    name: str|None = None,
-    **tractor_log_kwargs,
+    name: str = None,
+
 ) -> logging.Logger:
     '''
-    Return the package log or a sub-logger if a `name=` is provided,
-    which defaults to the calling module's pkg-namespace path.
-
-    See `tractor.log.get_logger()` for details.
+    Return the package log or a sub-log for `name` if provided.
 
     '''
-    pkg_name: str = _proj_name
-    if (
-        name
-        and
-        pkg_name in name
-    ):
-        name: str = name.lstrip(f'{_proj_name}.')
-
     return tractor.log.get_logger(
         name=name,
-        pkg_name=pkg_name,
-        **tractor_log_kwargs,
+        _root_name=_proj_name,
     )
 
 
 def get_console_log(
     level: str | None = None,
     name: str | None = None,
-    pkg_name: str|None = None,
-    with_tractor_log: bool = False,
-    # ?TODO, support a "log-spec" style `str|dict[str, str]` which
-    # dictates both the sublogger-key and a level?
-    # -> see similar idea in `modden`'s usage.
-    **tractor_log_kwargs,
 
 ) -> logging.Logger:
     '''
-    Get the package logger and enable a handler which writes to
-    stderr.
+    Get the package logger and enable a handler which writes to stderr.
 
-    Yeah yeah, i know we can use `DictConfig`.
-    You do it.. Bp
+    Yeah yeah, i know we can use ``DictConfig``. You do it...
 
     '''
-    pkg_name: str = _proj_name
-    if (
-        name
-        and
-        pkg_name in name
-    ):
-        name: str = name.lstrip(f'{_proj_name}.')
-
-    tll: str|None = None
-    if (
-        with_tractor_log is not False
-    ):
-        tll = level
-
-    elif maybe_actor := tractor.current_actor(
-        err_on_no_runtime=False,
-    ):
-        tll = maybe_actor.loglevel
-
-    if tll:
-        t_log = tractor.log.get_console_log(
-            level=tll,
-            name='tractor',  # <- XXX, force root tractor log!
-            **tractor_log_kwargs,
-        )
-        # TODO/ allow only enabling certain tractor sub-logs?
-        assert t_log.name == 'tractor'
-
     return tractor.log.get_console_log(
-        level=level,
+        level,
         name=name,
-        pkg_name=pkg_name,
-        **tractor_log_kwargs,
-    )
+        _root_name=_proj_name,
+    )  # our root logger
 
 
 def colorize_json(

piker/service/_actor_runtime.py

@@ -21,6 +21,7 @@
 from __future__ import annotations
 import os
 from typing import (
+    Optional,
     Any,
     ClassVar,
 )
@@ -31,11 +32,8 @@ from contextlib import (
 import tractor
 import trio
 
-from piker.log import (
-    get_console_log,
-)
 from ._util import (
-    subsys,
+    get_console_log,
 )
 from ._mngr import (
     Services,
@@ -61,7 +59,7 @@ async def open_piker_runtime(
     registry_addrs: list[tuple[str, int]] = [],
 
     enable_modules: list[str] = [],
-    loglevel: str|None = None,
+    loglevel: Optional[str] = None,
 
     # XXX NOTE XXX: you should pretty much never want debug mode
     # for data daemons when running in production.
@@ -99,8 +97,7 @@ async def open_piker_runtime(
         # setting it as the root actor on localhost.
         registry_addrs = (
             registry_addrs
-            or
-            [_default_reg_addr]
+            or [_default_reg_addr]
         )
 
         if ems := tractor_kwargs.pop('enable_modules', None):
@@ -166,6 +163,7 @@ _root_modules: list[str] = [
 @acm
 async def open_pikerd(
     registry_addrs: list[tuple[str, int]],
+
     loglevel: str | None = None,
 
     # XXX: you should pretty much never want debug mode
@@ -194,6 +192,7 @@ async def open_pikerd(
 
     async with (
         open_piker_runtime(
+
             name=_root_dname,
             loglevel=loglevel,
             debug_mode=debug_mode,
@@ -274,10 +273,7 @@ async def maybe_open_pikerd(
 
     '''
     if loglevel:
-        get_console_log(
-            name=subsys,
-            level=loglevel
-        )
+        get_console_log(loglevel)
 
     # subtle, we must have the runtime up here or portal lookup will fail
     query_name = kwargs.pop(

piker/service/_ahab.py

@@ -49,15 +49,13 @@ from requests.exceptions import (
     ReadTimeout,
 )
 
-from piker.log import (
-    get_console_log,
-    get_logger,
-)
 from ._mngr import Services
+from ._util import (
+    log,  # sub-sys logger
+    get_console_log,
+)
 from .. import config
 
-log = get_logger(name=__name__)
-
 
 class DockerNotStarted(Exception):
     'Prolly you dint start da daemon bruh'
@@ -338,16 +336,13 @@ class Container:
 async def open_ahabd(
     ctx: tractor.Context,
     endpoint: str,  # ns-pointer str-msg-type
-    loglevel: str = 'cancel',
+    loglevel: str | None = None,
 
     **ep_kwargs,
 
 ) -> None:
 
-    log = get_console_log(
-        level=loglevel,
-        name='piker.service',
-    )
+    log = get_console_log(loglevel or 'cancel')
 
     async with open_docker() as client:
 

piker/service/_daemon.py

@@ -30,9 +30,8 @@ from contextlib import (
 import tractor
 from trio.lowlevel import current_task
 
-from piker.log import (
-    get_console_log,
-    get_logger,
+from ._util import (
+    log,  # sub-sys logger
 )
 from ._mngr import (
     Services,
@@ -40,11 +39,10 @@ from ._mngr import (
 from ._actor_runtime import maybe_open_pikerd
 from ._registry import find_service
 
-log = get_logger(name=__name__)
-
 
 @acm
 async def maybe_spawn_daemon(
+
     service_name: str,
     service_task_target: Callable,
 
@@ -68,12 +66,6 @@ async def maybe_spawn_daemon(
     clients.
 
     '''
-    log = get_console_log(
-        level=loglevel,
-        name=__name__,
-    )
-    assert log.name == 'piker.service'
-
     # serialize access to this section to avoid
     # 2 or more tasks racing to create a daemon
     lock = Services.locks[service_name]
@@ -160,6 +152,7 @@ async def maybe_spawn_daemon(
 
 
 async def spawn_emsd(
+
     loglevel: str | None = None,
     **extra_tractor_kwargs
 
@@ -197,6 +190,7 @@ async def spawn_emsd(
 
 @acm
 async def maybe_open_emsd(
+
     brokername: str,
     loglevel: str | None = None,
 

piker/service/_mngr.py

@@ -34,9 +34,9 @@ from tractor import (
     Portal,
 )
 
-from piker.log import get_logger
-
-log = get_logger(name=__name__)
+from ._util import (
+    log,  # sub-sys logger
+)
 
 
 # TODO: we need remote wrapping and a general soln:

piker/service/_registry.py

@@ -27,29 +27,15 @@ from typing import (
 )
 
 import tractor
-from tractor import (
-    msg,
-    Actor,
-    Portal,
+from tractor import Portal
+
+from ._util import (
+    log,  # sub-sys logger
 )
 
-from piker.log import get_logger
-
-log = get_logger(name=__name__)
-
-# TODO? default path-space for UDS registry?
-# [ ] needs to be Xplatform tho!
-# _default_registry_path: Path = (
-#     Path(os.environ['XDG_RUNTIME_DIR'])
-#     /'piker'
-# )
-
 _default_registry_host: str = '127.0.0.1'
 _default_registry_port: int = 6116
-_default_reg_addr: tuple[
-    str,
-    int, # |str TODO, once we support UDS, see above.
-] = (
+_default_reg_addr: tuple[str, int] = (
     _default_registry_host,
     _default_registry_port,
 )
@@ -89,22 +75,16 @@ async def open_registry(
 
     '''
     global _tractor_kwargs
-    actor: Actor = tractor.current_actor()
-    aid: msg.Aid = actor.aid
-    uid: tuple[str, str] = aid.uid
-    preset_reg_addrs: list[
-        tuple[str, int]
-    ] = Registry.addrs
+    actor = tractor.current_actor()
+    uid = actor.uid
+    preset_reg_addrs: list[tuple[str, int]] = Registry.addrs
     if (
         preset_reg_addrs
-        and
-        addrs
+        and addrs
     ):
         if preset_reg_addrs != addrs:
             # if any(addr in preset_reg_addrs for addr in addrs):
-            diff: set[
-                tuple[str, int]
-            ] = set(preset_reg_addrs) - set(addrs)
+            diff: set[tuple[str, int]] = set(preset_reg_addrs) - set(addrs)
             if diff:
                 log.warning(
                     f'`{uid}` requested only subset of registrars: {addrs}\n'
@@ -118,6 +98,7 @@ async def open_registry(
                 )
 
     was_set: bool = False
+
     if (
         not tractor.is_root_process()
         and
@@ -134,23 +115,16 @@ async def open_registry(
             f"`{uid}` registry should already exist but doesn't?"
         )
 
-    if not Registry.addrs:
+    if (
+        not Registry.addrs
+    ):
         was_set = True
-        Registry.addrs = (
-            addrs
-            or
-            [_default_reg_addr]
-        )
+        Registry.addrs = addrs or [_default_reg_addr]
 
     # NOTE: only spot this seems currently used is inside
     # `.ui._exec` which is the (eventual qtloops) bootstrapping
     # with guest mode.
-    reg_addrs: list[tuple[str, str|int]] = Registry.addrs
-    # !TODO, a struct-API to stringently allow this only in special
-    # cases?
-    # -> better would be to have some way to (atomically) rewrite
-    #    and entire `RuntimeVars`?? ideas welcome obvi..
-    _tractor_kwargs['registry_addrs'] = reg_addrs
+    _tractor_kwargs['registry_addrs'] = Registry.addrs
 
     try:
         yield Registry.addrs
@@ -175,7 +149,7 @@ async def find_service(
     | None
 ):
     # try:
-    reg_addrs: list[tuple[str, int|str]]
+    reg_addrs: list[tuple[str, int]]
     async with open_registry(
         addrs=(
             registry_addrs
@@ -198,13 +172,15 @@ async def find_service(
             only_first=first_only,  # if set only returns single ref
         ) as maybe_portals:
             if not maybe_portals:
-                log.info(
+                # log.info(
+                print(
                     f'Could NOT find service {service_name!r} -> {maybe_portals!r}'
                 )
                 yield None
                 return
 
-            log.info(
+            # log.info(
+            print(
                 f'Found service {service_name!r} -> {maybe_portals}'
             )
             yield maybe_portals
@@ -219,6 +195,7 @@ async def find_service(
 
 async def check_for_service(
     service_name: str,
+
 ) -> None | tuple[str, int]:
     '''
     Service daemon "liveness" predicate.

piker/service/_util.py

@@ -14,12 +14,20 @@
 # You should have received a copy of the GNU Affero General Public License
 # along with this program.  If not, see <https://www.gnu.org/licenses/>.
 """
-Sub-sys module commons (if any ?? Bp).
+Sub-sys module commons.
 
 """
+from functools import partial
+
+from ..log import (
+    get_logger,
+    get_console_log,
+)
 subsys: str = 'piker.service'
 
-# ?TODO, if we were going to keep a `get_console_log()` in here to be
-# invoked at `import`-time, how do we dynamically hand in the
-# `level=` value? seems too early in the runtime to be injected
-# right?
+log = get_logger(subsys)
+
+get_console_log = partial(
+    get_console_log,
+    name=subsys,
+)

piker/service/elastic.py

@@ -16,7 +16,6 @@
 
 from __future__ import annotations
 from contextlib import asynccontextmanager as acm
-from pprint import pformat
 from typing import (
     Any,
     TYPE_CHECKING,
@@ -27,17 +26,12 @@ import asks
 if TYPE_CHECKING:
     import docker
     from ._ahab import DockerContainer
-    from . import (
-        Services,
-    )
 
-from piker.log import (
+from ._util import log  # sub-sys logger
+from ._util import (
     get_console_log,
-    get_logger,
 )
 
-log = get_logger(name=__name__)
-
 
 # container level config
 _config = {
@@ -73,10 +67,7 @@ def start_elasticsearch(
             elastic
 
     '''
-    get_console_log(
-        level='info',
-        name=__name__,
-    )
+    get_console_log('info', name=__name__)
 
     dcntr: DockerContainer = client.containers.run(
         'piker:elastic',

piker/service/marketstore.py

@@ -52,18 +52,17 @@ import pendulum
 # TODO: import this for specific error set expected by mkts client
 # import purerpc
 
-from piker.data.feed import maybe_open_feed
+from ..data.feed import maybe_open_feed
 from . import Services
-from piker.log import (
+from ._util import (
+    log,  # sub-sys logger
     get_console_log,
-    get_logger,
 )
 
 if TYPE_CHECKING:
     import docker
     from ._ahab import DockerContainer
 
-log = get_logger(name=__name__)
 
 
 # ahabd-supervisor and container level config

piker/tsp/_anal.py

@@ -54,10 +54,10 @@ from ..log import (
 # for "time series processing"
 subsys: str = 'piker.tsp'
 
-log = get_logger(name=__name__)
+log = get_logger(subsys)
 get_console_log = partial(
     get_console_log,
-    name=subsys,  # activate for subsys-pkg "downward"
+    name=subsys,
 )
 
 # NOTE: union type-defs to handle generic `numpy` and `polars` types

piker/tsp/_history.py

@@ -63,10 +63,8 @@ from ..data._sharedmem import (
     maybe_open_shm_array,
     ShmArray,
 )
-from piker.data._source import (
-    def_iohlcv_fields,
-)
-from piker.data._sampling import (
+from ..data._source import def_iohlcv_fields
+from ..data._sampling import (
     open_sample_stream,
 )
 
@@ -98,9 +96,7 @@ if TYPE_CHECKING:
     # from .feed import _FeedsBus
 
 
-log = get_logger(
-    name=__name__,
-)
+log = get_logger(__name__)
 
 
 # `ShmArray` buffer sizing configuration:
@@ -554,7 +550,7 @@ async def start_backfill(
                 )
                 # ?TODO, check against venue closure hours
                 # if/when provided by backend?
-                # await tractor.pause()
+                await tractor.pause()
 
             expected_dur: Interval = (
                 last_start_dt.subtract(
@@ -1324,7 +1320,6 @@ async def manage_history(
     mkt: MktPair,
     some_data_ready: trio.Event,
     feed_is_live: trio.Event,
-    loglevel: str = 'warning',
     timeframe: float = 60,  # in seconds
     wait_for_live_timeout: float = 0.5,
 
@@ -1502,7 +1497,6 @@ async def manage_history(
             # data feed layer that needs to consume it).
             open_index_stream=True,
             sub_for_broadcasts=False,
-            loglevel=loglevel,
 
         ) as sample_stream:
             # register 1s and 1m buffers with the global

piker/types.py

@@ -21,6 +21,230 @@ Extensions to built-in or (heavily used but 3rd party) friend-lib
 types.
 
 '''
-from tractor.msg.pretty_struct import (
-    Struct as Struct,
+from __future__ import annotations
+from collections import UserList
+from pprint import (
+    saferepr,
 )
+from typing import Any
+
+from msgspec import (
+    msgpack,
+    Struct as _Struct,
+    structs,
+)
+
+
+class DiffDump(UserList):
+    '''
+    Very simple list delegator that repr() dumps (presumed) tuple
+    elements of the form `tuple[str, Any, Any]` in a nice
+    multi-line readable form for analyzing `Struct` diffs.
+
+    '''
+    def __repr__(self) -> str:
+        if not len(self):
+            return super().__repr__()
+
+        # format by displaying item pair's ``repr()`` on multiple,
+        # indented lines such that they are more easily visually
+        # comparable when printed to console when printed to
+        # console.
+        repstr: str = '[\n'
+        for k, left, right in self:
+            repstr += (
+                f'({k},\n'
+                f'\t{repr(left)},\n'
+                f'\t{repr(right)},\n'
+                ')\n'
+            )
+        repstr += ']\n'
+        return repstr
+
+
+class Struct(
+    _Struct,
+
+    # https://jcristharif.com/msgspec/structs.html#tagged-unions
+    # tag='pikerstruct',
+    # tag=True,
+):
+    '''
+    A "human friendlier" (aka repl buddy) struct subtype.
+
+    '''
+    def _sin_props(self) -> Iterator[
+        tuple[
+            structs.FieldIinfo,
+            str,
+            Any,
+        ]
+    ]:
+        '''
+        Iterate over all non-@property fields of this struct.
+
+        '''
+        fi: structs.FieldInfo
+        for fi in structs.fields(self):
+            key: str = fi.name
+            val: Any = getattr(self, key)
+            yield fi, key, val
+
+    def to_dict(
+        self,
+        include_non_members: bool = True,
+
+    ) -> dict:
+        '''
+        Like it sounds.. direct delegation to:
+        https://jcristharif.com/msgspec/api.html#msgspec.structs.asdict
+
+        BUT, by default we pop all non-member (aka not defined as
+        struct fields) fields by default.
+
+        '''
+        asdict: dict = structs.asdict(self)
+        if include_non_members:
+            return asdict
+
+        # only return a dict of the struct members
+        # which were provided as input, NOT anything
+        # added as type-defined `@property` methods!
+        sin_props: dict = {}
+        fi: structs.FieldInfo
+        for fi, k, v in self._sin_props():
+            sin_props[k] = asdict[k]
+
+        return sin_props
+
+    def pformat(
+        self,
+        field_indent: int = 2,
+        indent: int = 0,
+
+    ) -> str:
+        '''
+        Recursion-safe `pprint.pformat()` style formatting of
+        a `msgspec.Struct` for sane reading by a human using a REPL.
+
+        '''
+        # global whitespace indent
+        ws: str = ' '*indent
+
+        # field whitespace indent
+        field_ws: str = ' '*(field_indent + indent)
+
+        # qtn: str = ws + self.__class__.__qualname__
+        qtn: str = self.__class__.__qualname__
+
+        obj_str: str = ''  # accumulator
+        fi: structs.FieldInfo
+        k: str
+        v: Any
+        for fi, k, v in self._sin_props():
+
+            # TODO: how can we prefer `Literal['option1',  'option2,
+            # ..]` over .__name__ == `Literal` but still get only the
+            # latter for simple types like `str | int | None` etc..?
+            ft: type = fi.type
+            typ_name: str = getattr(ft, '__name__', str(ft))
+
+            # recurse to get sub-struct's `.pformat()` output Bo
+            if isinstance(v, Struct):
+                val_str: str =  v.pformat(
+                    indent=field_indent + indent,
+                    field_indent=indent + field_indent,
+                )
+
+            else:  # the `pprint` recursion-safe format:
+                # https://docs.python.org/3.11/library/pprint.html#pprint.saferepr
+                val_str: str = saferepr(v)
+
+            obj_str += (field_ws + f'{k}: {typ_name} = {val_str},\n')
+
+        return (
+            f'{qtn}(\n'
+            f'{obj_str}'
+            f'{ws})'
+        )
+
+    # TODO: use a pprint.PrettyPrinter instance around ONLY rendering
+    # inside a known tty?
+    # def __repr__(self) -> str:
+    #     ...
+
+    # __str__ = __repr__ = pformat
+    __repr__ = pformat
+
+    def copy(
+        self,
+        update: dict | None = None,
+
+    ) -> Struct:
+        '''
+        Validate-typecast all self defined fields, return a copy of
+        us with all such fields.
+
+        NOTE: This is kinda like the default behaviour in
+        `pydantic.BaseModel` except a copy of the object is
+        returned making it compat with `frozen=True`.
+
+        '''
+        if update:
+            for k, v in update.items():
+                setattr(self, k, v)
+
+        # NOTE: roundtrip serialize to validate
+        # - enode to msgpack binary format,
+        # - decode that back to a struct.
+        return msgpack.Decoder(type=type(self)).decode(
+            msgpack.Encoder().encode(self)
+        )
+
+    def typecast(
+        self,
+
+        # TODO: allow only casting a named subset?
+        # fields: set[str] | None = None,
+
+    ) -> None:
+        '''
+        Cast all fields using their declared type annotations
+        (kinda like what `pydantic` does by default).
+
+        NOTE: this of course won't work on frozen types, use
+        ``.copy()`` above in such cases.
+
+        '''
+        # https://jcristharif.com/msgspec/api.html#msgspec.structs.fields
+        fi: structs.FieldInfo
+        for fi in structs.fields(self):
+            setattr(
+                self,
+                fi.name,
+                fi.type(getattr(self, fi.name)),
+            )
+
+    def __sub__(
+        self,
+        other: Struct,
+
+    ) -> DiffDump[tuple[str, Any, Any]]:
+        '''
+        Compare fields/items key-wise and return a ``DiffDump``
+        for easy visual REPL comparison B)
+
+        '''
+        diffs: DiffDump[tuple[str, Any, Any]] = DiffDump()
+        for fi in structs.fields(self):
+            attr_name: str = fi.name
+            ours: Any = getattr(self, attr_name)
+            theirs: Any = getattr(other, attr_name)
+            if ours != theirs:
+                diffs.append((
+                    attr_name,
+                    ours,
+                    theirs,
+                ))
+
+        return diffs

piker/ui/_app.py

@@ -33,10 +33,7 @@ from . import _search
 from ..accounting import unpack_fqme
 from ..data._symcache import open_symcache
 from ..data.feed import install_brokerd_search
-from ..log import (
-    get_logger,
-    get_console_log,
-)
+from ..log import get_logger
 from ..service import maybe_spawn_brokerd
 from ._exec import run_qtractor
 
@@ -90,13 +87,6 @@ async def _async_main(
     Provision the "main" widget with initial symbol data and root nursery.
 
     """
-    # enable chart's console logging
-    if loglevel:
-        get_console_log(
-            level=loglevel,
-            name=__name__,
-        )
-
     # set as singleton
     _chart._godw = main_widget
 

piker/ui/_chart.py

@@ -29,6 +29,7 @@ from typing import (
 )
 
 import pyqtgraph as pg
+import trio
 
 from piker.ui.qt import (
     QtCore,
@@ -40,7 +41,6 @@ from piker.ui.qt import (
     QVBoxLayout,
     QSplitter,
 )
-from ._widget import GodWidget
 from ._axes import (
     DynamicDateAxis,
     PriceAxis,
@@ -61,6 +61,10 @@ from ._style import (
     _xaxis_at,
     # _min_points_to_show,
 )
+from ..data.feed import (
+    Feed,
+    Flume,
+)
 from ..accounting import (
     MktPair,
 )
@@ -74,12 +78,305 @@ from . import _pg_overrides as pgo
 
 if TYPE_CHECKING:
     from ._display import DisplayState
-    from ..data.flows import Flume
-    from ..data.feed import Feed
 
 log = get_logger(__name__)
 
 
+_godw: GodWidget|None = None
+
+def get_godw() -> GodWidget:
+    '''
+    Get the top level "god widget", the root/central-most Qt
+    widget-object set as `QMainWindow.setCentralWidget(_godw)`.
+
+    See `piker.ui._exec` for the runtime init details and all the
+    machinery for running `trio` on the Qt event loop in guest mode.
+
+    '''
+    if _godw is None:
+        raise RuntimeError(
+            'No god-widget initialized ??\n'
+            'Have you called `run_qtractor()` yet?\n'
+        )
+    return _godw
+
+
+class GodWidget(QWidget):
+    '''
+    "Our lord and savior, the holy child of window-shua, there is no
+    widget above thee." - 6|6
+
+    The highest level composed widget which contains layouts for
+    organizing charts as well as other sub-widgets used to control or
+    modify them.
+
+    '''
+    search: SearchWidget
+    mode_name: str = 'god'
+
+    def __init__(
+
+        self,
+        parent=None,
+
+    ) -> None:
+
+        super().__init__(parent)
+
+        self.search: SearchWidget|None = None
+
+        self.hbox = QHBoxLayout(self)
+        self.hbox.setContentsMargins(0, 0, 0, 0)
+        self.hbox.setSpacing(6)
+        self.hbox.setAlignment(Qt.AlignTop)
+
+        self.vbox = QVBoxLayout()
+        self.vbox.setContentsMargins(0, 0, 0, 0)
+        self.vbox.setSpacing(2)
+        self.vbox.setAlignment(Qt.AlignTop)
+
+        self.hbox.addLayout(self.vbox)
+
+        self._chart_cache: dict[
+            str,
+            tuple[LinkedSplits, LinkedSplits],
+        ] = {}
+
+        self.hist_linked: LinkedSplits|None = None
+        self.rt_linked: LinkedSplits|None = None
+        self._active_cursor: Cursor|None = None
+
+        # assigned in the startup func `_async_main()`
+        self._root_n: trio.Nursery = None
+
+        self._widgets: dict[str, QWidget] = {}
+        self._resizing: bool = False
+
+        # TODO: do we need this, when would god get resized
+        # and the window does not? Never right?!
+        # self.reg_for_resize(self)
+
+    # TODO: strat loader/saver that we don't need yet.
+    # def init_strategy_ui(self):
+    #     self.toolbar_layout = QHBoxLayout()
+    #     self.toolbar_layout.setContentsMargins(0, 0, 0, 0)
+    #     self.vbox.addLayout(self.toolbar_layout)
+    #     self.strategy_box = StrategyBoxWidget(self)
+    #     self.toolbar_layout.addWidget(self.strategy_box)
+
+    @property
+    def linkedsplits(self) -> LinkedSplits:
+        return self.rt_linked
+
+    def set_chart_symbols(
+        self,
+        group_key: tuple[str],  # of form <fqme>.<providername>
+        all_linked: tuple[LinkedSplits, LinkedSplits],  # type: ignore
+
+    ) -> None:
+        # re-sort org cache symbol list in LIFO order
+        cache = self._chart_cache
+        cache.pop(group_key, None)
+        cache[group_key] = all_linked
+
+    def get_chart_symbols(
+        self,
+        symbol_key: str,
+
+    ) -> tuple[LinkedSplits, LinkedSplits]:  # type: ignore
+        return self._chart_cache.get(symbol_key)
+
+    async def load_symbols(
+        self,
+        fqmes: list[str],
+        loglevel: str,
+        reset: bool = False,
+
+    ) -> trio.Event:
+        '''
+        Load a new contract into the charting app.
+
+        Expects a ``numpy`` structured array containing all the ohlcv fields.
+
+        '''
+        # NOTE: for now we use the first symbol in the set as the "key"
+        # for the overlay of feeds on the chart.
+        group_key: tuple[str] = tuple(fqmes)
+
+        all_linked = self.get_chart_symbols(group_key)
+        order_mode_started = trio.Event()
+
+        if not self.vbox.isEmpty():
+
+            # XXX: seems to make switching slower?
+            # qframe = self.hist_linked.chart.qframe
+            # if qframe.sidepane is self.search:
+            #     qframe.hbox.removeWidget(self.search)
+
+            for linked in [self.rt_linked, self.hist_linked]:
+                # XXX: this is CRITICAL especially with pixel buffer caching
+                linked.hide()
+                linked.unfocus()
+
+                # XXX: pretty sure we don't need this
+                # remove any existing plots?
+                # XXX: ahh we might want to support cache unloading..
+                # self.vbox.removeWidget(linked)
+
+        # switching to a new viewable chart
+        if all_linked is None or reset:
+            from ._display import display_symbol_data
+
+            # we must load a fresh linked charts set
+            self.rt_linked = rt_charts = LinkedSplits(self)
+            self.hist_linked = hist_charts = LinkedSplits(self)
+
+            # spawn new task to start up and update new sub-chart instances
+            self._root_n.start_soon(
+                display_symbol_data,
+                self,
+                fqmes,
+                loglevel,
+                order_mode_started,
+            )
+
+            # self.vbox.addWidget(hist_charts)
+            self.vbox.addWidget(rt_charts)
+            self.set_chart_symbols(
+                group_key,
+                (hist_charts, rt_charts),
+            )
+
+            for linked in [hist_charts, rt_charts]:
+                linked.show()
+                linked.focus()
+
+            await trio.sleep(0)
+
+        else:
+            # symbol is already loaded and ems ready
+            order_mode_started.set()
+
+            self.hist_linked, self.rt_linked = all_linked
+
+            for linked in all_linked:
+                # TODO:
+                # - we'll probably want per-instrument/provider state here?
+                #   change the order config form over to the new chart
+
+                # chart is already in memory so just focus it
+                linked.show()
+                linked.focus()
+                linked.graphics_cycle()
+                await trio.sleep(0)
+
+                # resume feeds *after* rendering chart view asap
+                chart = linked.chart
+                if chart:
+                    chart.resume_all_feeds()
+
+            # TODO: we need a check to see if the chart
+            # last had the xlast in view, if so then shift so it's
+            # still in view, if the user was viewing history then
+            # do nothing yah?
+            self.rt_linked.chart.main_viz.default_view(
+                do_min_bars=True,
+            )
+
+        # if a history chart instance is already up then
+        # set the search widget as its sidepane.
+        hist_chart = self.hist_linked.chart
+        if hist_chart:
+            hist_chart.qframe.set_sidepane(self.search)
+
+            # NOTE: this is really stupid/hard to follow.
+            # we have to reposition the active position nav
+            # **AFTER** applying the search bar as a sidepane
+            # to the newly switched to symbol.
+            await trio.sleep(0)
+
+            # TODO: probably stick this in some kinda `LooknFeel` API?
+            for tracker in self.rt_linked.mode.trackers.values():
+                pp_nav = tracker.nav
+                if tracker.live_pp.cumsize:
+                    pp_nav.show()
+                    pp_nav.hide_info()
+                else:
+                    pp_nav.hide()
+
+        # set window titlebar info
+        symbol = self.rt_linked.mkt
+        if symbol is not None:
+            self.window.setWindowTitle(
+                f'{symbol.fqme} '
+                f'tick:{symbol.size_tick}'
+            )
+
+        return order_mode_started
+
+    def focus(self) -> None:
+        '''
+        Focus the top level widget which in turn focusses the chart
+        ala "view mode".
+
+        '''
+        # go back to view-mode focus (aka chart focus)
+        self.clearFocus()
+        chart = self.rt_linked.chart
+        if chart:
+            chart.setFocus()
+
+    def reg_for_resize(
+        self,
+        widget: QWidget,
+    ) -> None:
+        getattr(widget, 'on_resize')
+        self._widgets[widget.mode_name] = widget
+
+    def on_win_resize(self, event: QtCore.QEvent) -> None:
+        '''
+        Top level god widget handler from window (the real yaweh) resize
+        events such that any registered widgets which wish to be
+        notified are invoked using our pythonic `.on_resize()` method
+        api.
+
+        Where we do UX magic to make things not suck B)
+
+        '''
+        if self._resizing:
+            return
+
+        self._resizing = True
+
+        log.info('God widget resize')
+        for name, widget in self._widgets.items():
+            widget.on_resize()
+
+        self._resizing = False
+
+    # on_resize = on_win_resize
+
+    def get_cursor(self) -> Cursor:
+        return self._active_cursor
+
+    def iter_linked(self) -> Iterator[LinkedSplits]:
+        for linked in [self.hist_linked, self.rt_linked]:
+            yield linked
+
+    def resize_all(self) -> None:
+        '''
+        Dynamic resize sequence: adjusts all sub-widgets/charts to
+        sensible default ratios of what space is detected as available
+        on the display / window.
+
+        '''
+        rt_linked = self.rt_linked
+        rt_linked.set_split_sizes()
+        self.rt_linked.resize_sidepanes()
+        self.hist_linked.resize_sidepanes(from_linked=rt_linked)
+        self.search.on_resize()
+
+
 class ChartnPane(QFrame):
     '''
     One-off ``QFrame`` composite which pairs a chart
@@ -141,6 +438,7 @@ class LinkedSplits(QWidget):
 
     '''
     def __init__(
+
         self,
         godwidget: GodWidget,
 
@@ -752,7 +1050,7 @@ class ChartPlotWidget(pg.PlotWidget):
 
     ) -> None:
         '''
-        Increment the data view `datums`` steps toward y-axis thus
+        Increment the data view ``datums``` steps toward y-axis thus
         "following" the current time slot/step/bar.
 
         '''
@@ -762,7 +1060,7 @@ class ChartPlotWidget(pg.PlotWidget):
         x_shift = viz.index_step() * datums
 
         if datums >= 300:
-            log.warning('FUCKING FIX THE GLOBAL STEP BULLSHIT')
+            print("FUCKING FIX THE GLOBAL STEP BULLSHIT")
             # breakpoint()
             return
 

piker/ui/_cursor.py

@@ -413,18 +413,9 @@ class Cursor(pg.GraphicsObject):
         self,
         item: pg.GraphicsObject,
     ) -> None:
-        assert getattr(
-            item,
-            'delete',
-        ), f"{item} must define a ``.delete()``"
+        assert getattr(item, 'delete'), f"{item} must define a ``.delete()``"
         self._hovered.add(item)
 
-    def is_hovered(
-        self,
-        item: pg.GraphicsObject,
-    ) -> bool:
-        return item in self._hovered
-
     def add_plot(
         self,
         plot: ChartPlotWidget,  # noqa

piker/ui/_dataviz.py

@@ -45,7 +45,7 @@ from piker.ui.qt import QLineF
 from ..data._sharedmem import (
     ShmArray,
 )
-from ..data.flows import Flume
+from ..data.feed import Flume
 from ..data._formatters import (
     IncrementalFormatter,
     OHLCBarsFmtr,  # Plain OHLC renderer

piker/ui/_display.py

@@ -21,7 +21,6 @@ this module ties together quote and computational (fsp) streams with
 graphics update methods via our custom ``pyqtgraph`` charting api.
 
 '''
-from functools import partial
 import itertools
 from math import floor
 import time
@@ -209,7 +208,6 @@ class DisplayState(Struct):
 async def increment_history_view(
     # min_istream: tractor.MsgStream,
     ds: DisplayState,
-    loglevel: str = 'warning',
 ):
     hist_chart: ChartPlotWidget = ds.hist_chart
     hist_viz: Viz = ds.hist_viz
@@ -231,10 +229,7 @@ async def increment_history_view(
         hist_viz.reset_graphics()
         # hist_viz.update_graphics(force_redraw=True)
 
-    async with open_sample_stream(
-        period_s=1.,
-        loglevel=loglevel,
-    ) as min_istream:
+    async with open_sample_stream(1.) as min_istream:
         async for msg in min_istream:
 
             profiler = Profiler(
@@ -315,6 +310,7 @@ async def increment_history_view(
 
 
 async def graphics_update_loop(
+
     dss: dict[str, DisplayState],
     nurse: trio.Nursery,
     godwidget: GodWidget,
@@ -323,7 +319,6 @@ async def graphics_update_loop(
 
     pis: dict[str, list[pgo.PlotItem, pgo.PlotItem]] = {},
     vlm_charts: dict[str, ChartPlotWidget] = {},
-    loglevel: str = 'warning',
 
 ) -> None:
     '''
@@ -467,12 +462,9 @@ async def graphics_update_loop(
         # })
 
         nurse.start_soon(
-            partial(
             increment_history_view,
             # min_istream,
-                ds=ds,
-                loglevel=loglevel,
-            ),
+            ds,
         )
         await trio.sleep(0)
 
@@ -519,19 +511,14 @@ async def graphics_update_loop(
                     fast_chart.linked.isHidden()
                     or not rt_pi.isVisible()
                 ):
-                    log.debug(
-                        f'{fqme} skipping update for HIDDEN CHART'
-                    )
+                    print(f'{fqme} skipping update for HIDDEN CHART')
                     fast_chart.pause_all_feeds()
                     continue
 
                 ic = fast_chart.view._in_interact
                 if ic:
                     fast_chart.pause_all_feeds()
-                    log.debug(
-                        f'Pausing chart updaates during interaction\n'
-                        f'fqme: {fqme!r}'
-                    )
+                    print(f'{fqme} PAUSING DURING INTERACTION')
                     await ic.wait()
                     fast_chart.resume_all_feeds()
 
@@ -1604,18 +1591,15 @@ async def display_symbol_data(
             # start update loop task
             dss: dict[str, DisplayState] = {}
             ln.start_soon(
-                partial(
                 graphics_update_loop,
-                    dss=dss,
-                    nurse=ln,
-                    godwidget=godwidget,
-                    feed=feed,
+                dss,
+                ln,
+                godwidget,
+                feed,
                 # min_istream,
 
-                    pis=pis,
-                    vlm_charts=vlm_charts,
-                    loglevel=loglevel,
-                )
+                pis,
+                vlm_charts,
             )
 
             # boot order-mode

piker/ui/_editors.py

@@ -55,11 +55,6 @@ from ._style import (
 from ._lines import LevelLine
 from ..log import get_logger
 
-# TODO, rm the cycle here!
-from ._widget import (
-    GodWidget,
-)
-
 if TYPE_CHECKING:
     from ._chart import (
         GodWidget,

piker/ui/_exec.py

@@ -56,7 +56,7 @@ from . import _style
 
 
 if TYPE_CHECKING:
-    from ._widget import GodWidget
+    from ._chart import GodWidget
 
 
 log = get_logger(__name__)

piker/ui/_fsp.py

@@ -183,17 +183,13 @@ async def open_fsp_sidepane(
 
 @acm
 async def open_fsp_actor_cluster(
-    names: list[str] = [
-        'fsp_0',
-        'fsp_1',
-    ],
+    names: list[str] = ['fsp_0', 'fsp_1'],
 
 ) -> AsyncGenerator[
     int,
     dict[str, tractor.Portal]
 ]:
 
-    # TODO! change to .experimental!
     from tractor._clustering import open_actor_cluster
 
     # profiler = Profiler(
@@ -201,7 +197,7 @@ async def open_fsp_actor_cluster(
     #     disabled=False
     # )
     async with open_actor_cluster(
-        count=len(names),
+        count=2,
         names=names,
         modules=['piker.fsp._engine'],
 
@@ -501,8 +497,7 @@ class FspAdmin:
 
         portal: tractor.Portal = (
             self.cluster.get(worker_name)
-            or
-            self.rr_next_portal()
+            or self.rr_next_portal()
         )
 
         # TODO: this should probably be turned into a

piker/ui/_interaction.py

@@ -43,7 +43,6 @@ from pyqtgraph import (
     functions as fn,
 )
 import numpy as np
-import tractor
 import trio
 
 from piker.ui.qt import (
@@ -73,10 +72,7 @@ if TYPE_CHECKING:
         GodWidget,
     )
     from ._dataviz import Viz
-    from .order_mode import (
-        OrderMode,
-        Dialog,
-    )
+    from .order_mode import OrderMode
     from ._display import DisplayState
 
 
@@ -134,12 +130,7 @@ async def handle_viewmode_kb_inputs(
 
     async for kbmsg in recv_chan:
         event, etype, key, mods, text = kbmsg.to_tuple()
-        log.debug(
-            f'View-mode kb-msg received,\n'
-            f'mods: {mods!r}\n'
-            f'key: {key!r}\n'
-            f'text: {text!r}\n'
-        )
+        log.debug(f'key: {key}, mods: {mods}, text: {text}')
         now = time.time()
         period = now - last
 
@@ -167,12 +158,8 @@ async def handle_viewmode_kb_inputs(
             # have no previous keys or we do and the min_tap period is
             # met
             if (
-                not fast_key_seq
-                or (
-                    period <= min_tap
-                    and
-                    fast_key_seq
-                )
+                not fast_key_seq or
+                period <= min_tap and fast_key_seq
             ):
                 fast_key_seq.append(text)
                 log.debug(f'fast keys seqs {fast_key_seq}')
@@ -187,8 +174,7 @@ async def handle_viewmode_kb_inputs(
             # UI REPL-shell, with ctrl-p (for "pause")
             if (
                 ctrl
-                and
-                key in {
+                and key in {
                     Qt.Key_P,
                 }
             ):
@@ -198,6 +184,7 @@ async def handle_viewmode_kb_inputs(
                 vlm_chart = chart.linked.subplots['volume']  # noqa
                 vlm_viz = vlm_chart.main_viz  # noqa
                 dvlm_pi = vlm_chart._vizs['dolla_vlm'].plot  # noqa
+                import tractor
                 await tractor.pause()
                 view.interact_graphics_cycle()
 
@@ -205,8 +192,7 @@ async def handle_viewmode_kb_inputs(
             # shown data `Viz`s for the current chart app.
             if (
                 ctrl
-                and
-                key in {
+                and key in {
                     Qt.Key_R,
                 }
             ):
@@ -245,8 +231,7 @@ async def handle_viewmode_kb_inputs(
                 key == Qt.Key_Escape
                 or (
                     ctrl
-                    and
-                    key == Qt.Key_C
+                    and key == Qt.Key_C
                 )
             ):
                 # ctrl-c as cancel
@@ -257,35 +242,17 @@ async def handle_viewmode_kb_inputs(
             # cancel order or clear graphics
             if (
                 key == Qt.Key_C
-                or
-                key == Qt.Key_Delete
+                or key == Qt.Key_Delete
             ):
-                # log.info('Handling <c> hotkey!')
-                try:
-                    dialogs: list[Dialog] = order_mode.cancel_orders_under_cursor()
-                except BaseException:
-                    log.exception('Failed to cancel orders !?\n')
-                    await tractor.pause()
 
-                if not dialogs:
-                    log.warning(
-                        'No orders were cancelled?\n'
-                        'Is there an order-line under the cursor?\n'
-                        'If you think there IS your DE might be "hiding the mouse" before '
-                        'we rx the keyboard input via Qt..\n'
-                        '=> Check your DE and/or TWM settings to be sure! <=\n'
-                    )
-                    # ^TODO?, some way to detect if there's lines and
-                    # the DE is cuckin with things?
-                    # await tractor.pause()
+                order_mode.cancel_orders_under_cursor()
 
             # View modes
             if (
                 ctrl
                 and (
                     key == Qt.Key_Equal
-                    or
-                    key == Qt.Key_I
+                    or key == Qt.Key_I
                 )
             ):
                 view.wheelEvent(
@@ -297,8 +264,7 @@ async def handle_viewmode_kb_inputs(
                 ctrl
                 and (
                     key == Qt.Key_Minus
-                    or
-                    key == Qt.Key_O
+                    or key == Qt.Key_O
                 )
             ):
                 view.wheelEvent(
@@ -309,8 +275,7 @@ async def handle_viewmode_kb_inputs(
 
             elif (
                 not ctrl
-                and
-                key == Qt.Key_R
+                and key == Qt.Key_R
             ):
                 # NOTE: seems that if we don't yield a Qt render
                 # cycle then the m4 downsampled curves will show here
@@ -512,8 +477,7 @@ async def handle_viewmode_mouse(
         #     view.raiseContextMenu(event)
 
         if (
-            view.order_mode.active
-            and
+            view.order_mode.active and
             button == QtCore.Qt.LeftButton
         ):
             # when in order mode, submit execution
@@ -817,8 +781,7 @@ class ChartView(ViewBox):
 
         # Scale or translate based on mouse button
         if btn & (
-            QtCore.Qt.LeftButton
-            | QtCore.Qt.MidButton
+            QtCore.Qt.LeftButton | QtCore.Qt.MidButton
         ):
             # zoom y-axis ONLY when click-n-drag on it
             # if axis == 1:

piker/ui/_lines.py

@@ -52,13 +52,10 @@ from ._anchors import (
 from ..calc import humanize
 from ._label import Label
 from ._style import hcolor, _font
-from ..log import get_logger
 
 if TYPE_CHECKING:
     from ._cursor import Cursor
 
-log = get_logger(__name__)
-
 
 # TODO: probably worth investigating if we can
 # make .boundingRect() faster:
@@ -350,7 +347,7 @@ class LevelLine(pg.InfiniteLine):
 
     ) -> None:
         # TODO: enter labels edit mode
-        log.debug(f'double click {ev}')
+        print(f'double click {ev}')
 
     def paint(
         self,
@@ -464,19 +461,10 @@ class LevelLine(pg.InfiniteLine):
         # hovered
         if (
             not ev.isExit()
-            and
-            ev.acceptDrags(QtCore.Qt.LeftButton)
+            and ev.acceptDrags(QtCore.Qt.LeftButton)
         ):
             # if already hovered we don't need to run again
-            if (
-                self.mouseHovering is True
-                and
-                cur.is_hovered(self)
-            ):
-                log.debug(
-                    f'Already hovering ??\n'
-                    f'cur._hovered: {cur._hovered!r}\n'
-                )
+            if self.mouseHovering is True:
                 return
 
             if self.only_show_markers_on_hover:
@@ -493,7 +481,6 @@ class LevelLine(pg.InfiniteLine):
                     cur._y_label_update = False
 
             # add us to cursor state
-            log.debug(f'Adding line {self!r}\n')
             cur.add_hovered(self)
 
             if self._hide_xhair_on_hover:
@@ -521,7 +508,6 @@ class LevelLine(pg.InfiniteLine):
 
             self.currentPen = self.pen
 
-            log.debug(f'Removing line {self!r}\n')
             cur._hovered.remove(self)
 
             if self.only_show_markers_on_hover:

piker/ui/_widget.py

@@ -1,352 +0,0 @@
-# piker: trading gear for hackers
-# Copyright (C) Tyler Goodlet (in stewardship for pikers)
-
-# This program is free software: you can redistribute it and/or modify
-# it under the terms of the GNU Affero General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
-
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU Affero General Public License for more details.
-
-# You should have received a copy of the GNU Affero General Public License
-# along with this program.  If not, see <https://www.gnu.org/licenses/>.
-
-'''
-Root-most (what they call a "central widget") of every Qt-UI-app's
-window.
-
-'''
-from __future__ import annotations
-from typing import (
-    Iterator,
-    TYPE_CHECKING,
-)
-
-import trio
-
-from piker.ui.qt import (
-    QtCore,
-    Qt,
-    QWidget,
-    QHBoxLayout,
-    QVBoxLayout,
-)
-from ..log import get_logger
-
-if TYPE_CHECKING:
-    from ._search import SearchWidget
-    from ._chart import (
-        LinkedSplits,
-    )
-    from ._cursor import (
-        Cursor,
-    )
-
-
-log = get_logger(__name__)
-
-_godw: GodWidget|None = None
-
-def get_godw() -> GodWidget:
-    '''
-    Get the top level "god widget", the root/central-most Qt
-    widget-object set as `QMainWindow.setCentralWidget(_godw)`.
-
-    See `piker.ui._exec` for the runtime init details and all the
-    machinery for running `trio` on the Qt event loop in guest mode.
-
-    '''
-    if _godw is None:
-        raise RuntimeError(
-            'No god-widget initialized ??\n'
-            'Have you called `run_qtractor()` yet?\n'
-        )
-    return _godw
-
-
-class GodWidget(QWidget):
-    '''
-    "Our lord and savior, the holy child of window-shua, there is no
-    widget above thee." - 6|6
-
-    The highest level composed widget which contains layouts for
-    organizing charts as well as other sub-widgets used to control or
-    modify them.
-
-    '''
-    search: SearchWidget
-    mode_name: str = 'god'
-
-    def __init__(
-
-        self,
-        parent=None,
-
-    ) -> None:
-
-        super().__init__(parent)
-
-        self.search: SearchWidget|None = None
-
-        self.hbox = QHBoxLayout(self)
-        self.hbox.setContentsMargins(0, 0, 0, 0)
-        self.hbox.setSpacing(6)
-        self.hbox.setAlignment(Qt.AlignTop)
-
-        self.vbox = QVBoxLayout()
-        self.vbox.setContentsMargins(0, 0, 0, 0)
-        self.vbox.setSpacing(2)
-        self.vbox.setAlignment(Qt.AlignTop)
-
-        self.hbox.addLayout(self.vbox)
-
-        self._chart_cache: dict[
-            str,
-            tuple[LinkedSplits, LinkedSplits],
-        ] = {}
-
-        self.hist_linked: LinkedSplits|None = None
-        self.rt_linked: LinkedSplits|None = None
-        self._active_cursor: Cursor|None = None
-
-        # assigned in the startup func `_async_main()`
-        self._root_n: trio.Nursery = None
-
-        self._widgets: dict[str, QWidget] = {}
-        self._resizing: bool = False
-
-        # TODO: do we need this, when would god get resized
-        # and the window does not? Never right?!
-        # self.reg_for_resize(self)
-
-    # TODO: strat loader/saver that we don't need yet.
-    # def init_strategy_ui(self):
-    #     self.toolbar_layout = QHBoxLayout()
-    #     self.toolbar_layout.setContentsMargins(0, 0, 0, 0)
-    #     self.vbox.addLayout(self.toolbar_layout)
-    #     self.strategy_box = StrategyBoxWidget(self)
-    #     self.toolbar_layout.addWidget(self.strategy_box)
-
-    @property
-    def linkedsplits(self) -> LinkedSplits:
-        return self.rt_linked
-
-    def set_chart_symbols(
-        self,
-        group_key: tuple[str],  # of form <fqme>.<providername>
-        all_linked: tuple[LinkedSplits, LinkedSplits],  # type: ignore
-
-    ) -> None:
-        # re-sort org cache symbol list in LIFO order
-        cache = self._chart_cache
-        cache.pop(group_key, None)
-        cache[group_key] = all_linked
-
-    def get_chart_symbols(
-        self,
-        symbol_key: str,
-
-    ) -> tuple[LinkedSplits, LinkedSplits]:  # type: ignore
-        return self._chart_cache.get(symbol_key)
-
-    async def load_symbols(
-        self,
-        fqmes: list[str],
-        loglevel: str,
-        reset: bool = False,
-
-    ) -> trio.Event:
-        '''
-        Load a new contract into the charting app.
-
-        Expects a ``numpy`` structured array containing all the ohlcv fields.
-
-        '''
-        # NOTE: for now we use the first symbol in the set as the "key"
-        # for the overlay of feeds on the chart.
-        group_key: tuple[str] = tuple(fqmes)
-
-        all_linked = self.get_chart_symbols(group_key)
-        order_mode_started = trio.Event()
-
-        if not self.vbox.isEmpty():
-
-            # XXX: seems to make switching slower?
-            # qframe = self.hist_linked.chart.qframe
-            # if qframe.sidepane is self.search:
-            #     qframe.hbox.removeWidget(self.search)
-
-            for linked in [self.rt_linked, self.hist_linked]:
-                # XXX: this is CRITICAL especially with pixel buffer caching
-                linked.hide()
-                linked.unfocus()
-
-                # XXX: pretty sure we don't need this
-                # remove any existing plots?
-                # XXX: ahh we might want to support cache unloading..
-                # self.vbox.removeWidget(linked)
-
-        # switching to a new viewable chart
-        if all_linked is None or reset:
-            from ._display import display_symbol_data
-
-            # we must load a fresh linked charts set
-            from ._chart import LinkedSplits
-            self.rt_linked = rt_charts = LinkedSplits(self)
-            self.hist_linked = hist_charts = LinkedSplits(self)
-
-            # spawn new task to start up and update new sub-chart instances
-            self._root_n.start_soon(
-                display_symbol_data,
-                self,
-                fqmes,
-                loglevel,
-                order_mode_started,
-            )
-
-            # self.vbox.addWidget(hist_charts)
-            self.vbox.addWidget(rt_charts)
-            self.set_chart_symbols(
-                group_key,
-                (hist_charts, rt_charts),
-            )
-
-            for linked in [hist_charts, rt_charts]:
-                linked.show()
-                linked.focus()
-
-            await trio.sleep(0)
-
-        else:
-            # symbol is already loaded and ems ready
-            order_mode_started.set()
-
-            self.hist_linked, self.rt_linked = all_linked
-
-            for linked in all_linked:
-                # TODO:
-                # - we'll probably want per-instrument/provider state here?
-                #   change the order config form over to the new chart
-
-                # chart is already in memory so just focus it
-                linked.show()
-                linked.focus()
-                linked.graphics_cycle()
-                await trio.sleep(0)
-
-                # resume feeds *after* rendering chart view asap
-                chart = linked.chart
-                if chart:
-                    chart.resume_all_feeds()
-
-            # TODO: we need a check to see if the chart
-            # last had the xlast in view, if so then shift so it's
-            # still in view, if the user was viewing history then
-            # do nothing yah?
-            self.rt_linked.chart.main_viz.default_view(
-                do_min_bars=True,
-            )
-
-        # if a history chart instance is already up then
-        # set the search widget as its sidepane.
-        hist_chart = self.hist_linked.chart
-        if hist_chart:
-            hist_chart.qframe.set_sidepane(self.search)
-
-            # NOTE: this is really stupid/hard to follow.
-            # we have to reposition the active position nav
-            # **AFTER** applying the search bar as a sidepane
-            # to the newly switched to symbol.
-            await trio.sleep(0)
-
-            # TODO: probably stick this in some kinda `LooknFeel` API?
-            for tracker in self.rt_linked.mode.trackers.values():
-                pp_nav = tracker.nav
-                if tracker.live_pp.cumsize:
-                    pp_nav.show()
-                    pp_nav.hide_info()
-                else:
-                    pp_nav.hide()
-
-        # set window titlebar info
-        symbol = self.rt_linked.mkt
-        if symbol is not None:
-            self.window.setWindowTitle(
-                f'{symbol.fqme} '
-                f'tick:{symbol.size_tick}'
-            )
-
-        return order_mode_started
-
-    def focus(self) -> None:
-        '''
-        Focus the top level widget which in turn focusses the chart
-        ala "view mode".
-
-        '''
-        # go back to view-mode focus (aka chart focus)
-        self.clearFocus()
-        chart = self.rt_linked.chart
-        if chart:
-            chart.setFocus()
-
-    def reg_for_resize(
-        self,
-        widget: QWidget,
-    ) -> None:
-        getattr(widget, 'on_resize')
-        self._widgets[widget.mode_name] = widget
-
-    def on_win_resize(
-        self,
-        event: QtCore.QEvent,
-    ) -> None:
-        '''
-        Top level god widget handler from window (the real yaweh) resize
-        events such that any registered widgets which wish to be
-        notified are invoked using our pythonic `.on_resize()` method
-        api.
-
-        Where we do UX magic to make things not suck B)
-
-        '''
-        if self._resizing:
-            return
-
-        self._resizing = True
-
-        log.debug(
-            f'God widget resize\n'
-            f'{event}\n'
-        )
-        for name, widget in self._widgets.items():
-            widget.on_resize()
-
-        self._resizing = False
-
-    # on_resize = on_win_resize
-
-    def get_cursor(self) -> Cursor:
-        return self._active_cursor
-
-    def iter_linked(self) -> Iterator[LinkedSplits]:
-        for linked in [self.hist_linked, self.rt_linked]:
-            yield linked
-
-    def resize_all(self) -> None:
-        '''
-        Dynamic resize sequence: adjusts all sub-widgets/charts to
-        sensible default ratios of what space is detected as available
-        on the display / window.
-
-        '''
-        rt_linked = self.rt_linked
-        rt_linked.set_split_sizes()
-        self.rt_linked.resize_sidepanes()
-        self.hist_linked.resize_sidepanes(from_linked=rt_linked)
-        self.search.on_resize()
-
-

piker/ui/_window.py

@@ -40,7 +40,7 @@ from piker.ui.qt import (
 )
 from ..log import get_logger
 from ._style import _font_small, hcolor
-from ._widget import GodWidget
+from ._chart import GodWidget
 
 
 log = get_logger(__name__)
@@ -255,16 +255,8 @@ class MainWindow(QMainWindow):
         current: QWidget,
 
     ) -> None:
-        '''
-        Focus handler.
 
-        For now updates the "current mode" name.
-
-        '''
-        log.debug(
-            f'widget focus changed from,\n'
-            f'{last} -> {current}'
-        )
+        log.info(f'widget focus changed from {last} -> {current}')
 
         if current is not None:
             # cursor left window?

piker/ui/cli.py

@@ -177,7 +177,7 @@ def chart(
             return
 
     # global opts
-    # brokernames: list[str] = config['brokers']
+    brokernames = config['brokers']
     brokermods = config['brokermods']
     assert brokermods
     tractorloglevel = config['tractorloglevel']
@@ -216,7 +216,6 @@ def chart(
                 layers['tcp']['port'],
             ))
 
-    # breakpoint()
     from tractor.devx import maybe_open_crash_handler
     pdb: bool = config['pdb']
     with maybe_open_crash_handler(pdb=pdb):

piker/ui/order_mode.py

@@ -77,6 +77,7 @@ from ._style import _font
 from ._forms import open_form_input_handling
 from ._notify import notify_from_ems_status_msg
 
+
 if TYPE_CHECKING:
     from ._chart import (
         ChartPlotWidget,
@@ -435,7 +436,7 @@ class OrderMode:
             lines=lines,
             last_status_close=self.multistatus.open_status(
                 f'submitting {order.exec_mode}-{order.action}',
-                # final_msg=f'submitted {order.exec_mode}-{order.action}',
+                final_msg=f'submitted {order.exec_mode}-{order.action}',
                 clear_on_next=True,
             )
         )
@@ -519,8 +520,7 @@ class OrderMode:
         '''
         Order submitted status event handler.
 
-        Commit the order line and registered order uuid, store ack
-        time stamp.
+        Commit the order line and registered order uuid, store ack time stamp.
 
         '''
         lines = self.lines.commit_line(uuid)
@@ -658,7 +658,7 @@ class OrderMode:
         return True
 
 
-    def cancel_orders_under_cursor(self) -> list[Dialog]:
+    def cancel_orders_under_cursor(self) -> list[str]:
         return self.cancel_orders(
             self.oids_from_lines(
                 self.lines.lines_under_cursor()
@@ -687,28 +687,24 @@ class OrderMode:
         self,
         oids: list[str],
 
-    ) -> list[Dialog]:
+    ) -> None:
         '''
         Cancel all orders from a list of order ids: `oids`.
 
         '''
-        # key = self.multistatus.open_status(
-        #     f'cancelling {len(oids)} orders',
-        #     final_msg=f'cancelled orders:\n{oids}',
-        #     group_key=True
-        # )
-        dialogs: list[Dialog] = []
+        key = self.multistatus.open_status(
+            f'cancelling {len(oids)} orders',
+            final_msg=f'cancelled orders:\n{oids}',
+            group_key=True
+        )
         for oid in oids:
             if dialog := self.dialogs.get(oid):
                 self.client.cancel_nowait(uuid=oid)
-                # cancel_status_close = self.multistatus.open_status(
-                #     f'cancelling order {oid}',
-                #     group_key=key,
-                # )
-                # dialog.last_status_close = cancel_status_close
-                dialogs.append(dialog)
-
-        return dialogs
+                cancel_status_close = self.multistatus.open_status(
+                    f'cancelling order {oid}',
+                    group_key=key,
+                )
+                dialog.last_status_close = cancel_status_close
 
     def cancel_all_orders(self) -> None:
         '''
@@ -780,6 +776,7 @@ class OrderMode:
 
 @asynccontextmanager
 async def open_order_mode(
+
     feed: Feed,
     godw: GodWidget,
     fqme: str,

uv.lock

@@ -1243,11 +1243,11 @@ uis = [
 
 [[package]]
 name = "platformdirs"
-version = "4.6.0"
+version = "4.5.1"
 source = { registry = "https://pypi.org/simple" }
-sdist = { url = "https://files.pythonhosted.org/packages/20/e5/474d0a8508029286b905622e6929470fb84337cfa08f9d09fbb624515249/platformdirs-4.6.0.tar.gz", hash = "sha256:4a13c2db1071e5846c3b3e04e5b095c0de36b2a24be9a3bc0145ca66fce4e328", size = 23433, upload-time = "2026-02-12T14:36:21.288Z" }
+sdist = { url = "https://files.pythonhosted.org/packages/cf/86/0248f086a84f01b37aaec0fa567b397df1a119f73c16f6c7a9aac73ea309/platformdirs-4.5.1.tar.gz", hash = "sha256:61d5cdcc6065745cdd94f0f878977f8de9437be93de97c1c12f853c9c0cdcbda", size = 21715, upload-time = "2025-12-05T13:52:58.638Z" }
 wheels = [
-    { url = "https://files.pythonhosted.org/packages/da/10/1b0dcf51427326f70e50d98df21b18c228117a743a1fc515a42f8dc7d342/platformdirs-4.6.0-py3-none-any.whl", hash = "sha256:dd7f808d828e1764a22ebff09e60f175ee3c41876606a6132a688d809c7c9c73", size = 19549, upload-time = "2026-02-12T14:36:19.743Z" },
+    { url = "https://files.pythonhosted.org/packages/cb/28/3bfe2fa5a7b9c46fe7e13c97bda14c895fb10fa2ebf1d0abb90e0cea7ee1/platformdirs-4.5.1-py3-none-any.whl", hash = "sha256:d03afa3963c806a9bed9d5125c8f4cb2fdaf74a55ab60e5d59b3fde758104d31", size = 18731, upload-time = "2025-12-05T13:52:56.823Z" },
 ]
 
 [[package]]
@@ -2006,7 +2006,7 @@ dev = [
     { name = "pytest", specifier = ">=8.3.5" },
     { name = "stackscope", specifier = ">=0.2.2,<0.3" },
     { name = "typing-extensions", specifier = ">=4.14.1" },
-    { name = "xonsh", specifier = ">=0.22.2" },
+    { name = "xonsh", specifier = ">=0.19.2" },
 ]
 devx = [
     { name = "greenback", specifier = ">=1.2.1,<2" },
@@ -2018,7 +2018,7 @@ repl = [
     { name = "prompt-toolkit", specifier = ">=3.0.50" },
     { name = "psutil", specifier = ">=7.0.0" },
     { name = "pyperclip", specifier = ">=1.9.0" },
-    { name = "xonsh", specifier = ">=0.22.2" },
+    { name = "xonsh", specifier = ">=0.19.2" },
 ]
 testing = [
     { name = "pexpect", specifier = ">=4.9.0,<5" },
@@ -2264,8 +2264,8 @@ wheels = [
 
 [[package]]
 name = "xonsh"
-version = "0.22.3"
-source = { git = "https://github.com/xonsh/xonsh.git?branch=main#b446946fd94c3913e002318db1d1b41ee4fa1f9a" }
+version = "0.22.1"
+source = { git = "https://github.com/xonsh/xonsh.git?branch=main#336658ff0919f8d7bb96d581136d37d470a8fe99" }
 
 [[package]]
 name = "yapic-json"