Update feed test fqmes to use `.<venue>` format
Switch all `test_feeds.py` parametrized fqmes from legacy `<pair>.<broker>` to the current `<pair>.<venue>.<broker>` schema (e.g. `btcusdt.spot.binance`). Deats, - update binance fqmes: `btcusdt.binance` -> `btcusdt.spot.binance`, same for `ethusdt`. - update kraken fqmes: `ethusdt.kraken` -> `ethusdt.spot.kraken`, `xbtusd.kraken` -> `xbtusd.spot.kraken`. - update cross-broker set similarly. - comment out old fqmes with `!TODO` to later validate raising on bad/legacy formats. Also, - reformat `if ci_env and not run_in_ci` to multiline style. - reformat `pytest.skip()` msg to multiline. - add `?TODO` for symbology helper fn. - drop stray `await tractor.pause()` in `conftest.py`. (this commit msg was generated in some part by [`claude-code`][claude-code-gh]) [claude-code-gh]: https://github.com/anthropics/claude-coderepair_tests
parent
84c742a885
commit
8424c368f6
|
|
@ -137,7 +137,6 @@ async def _open_test_pikerd(
|
||||||
raddr = portal.chan.raddr
|
raddr = portal.chan.raddr
|
||||||
uw_raddr: tuple = raddr.unwrap()
|
uw_raddr: tuple = raddr.unwrap()
|
||||||
assert uw_raddr == reg_addr
|
assert uw_raddr == reg_addr
|
||||||
await tractor.pause()
|
|
||||||
yield (
|
yield (
|
||||||
raddr._host,
|
raddr._host,
|
||||||
raddr._port,
|
raddr._port,
|
||||||
|
|
|
||||||
|
|
@ -23,13 +23,35 @@ from piker.accounting import (
|
||||||
'fqmes',
|
'fqmes',
|
||||||
[
|
[
|
||||||
# binance
|
# binance
|
||||||
(100, {'btcusdt.binance', 'ethusdt.binance'}, False),
|
(100, {
|
||||||
|
# !TODO, write a suite which validates raising against
|
||||||
|
# bad/legacy fqmes such as this!
|
||||||
|
# 'btcusdt.binance',
|
||||||
|
'btcusdt.spot.binance',
|
||||||
|
'ethusdt.spot.binance',
|
||||||
|
}, False),
|
||||||
|
|
||||||
# kraken
|
# kraken
|
||||||
(20, {'ethusdt.kraken', 'xbtusd.kraken'}, True),
|
(20, {
|
||||||
|
# !TODO, write a suite which validates raising against
|
||||||
|
# bad/legacy fqmes such as this!
|
||||||
|
# 'ethusdt.kraken',
|
||||||
|
# 'xbtusd.kraken',
|
||||||
|
|
||||||
|
'ethusdt.spot.kraken',
|
||||||
|
'xbtusd.spot.kraken',
|
||||||
|
}, True),
|
||||||
|
|
||||||
# binance + kraken
|
# binance + kraken
|
||||||
(100, {'btcusdt.binance', 'xbtusd.kraken'}, False),
|
(100, {
|
||||||
|
# !TODO, write a suite which validates raising against
|
||||||
|
# bad/legacy fqmes such as this!
|
||||||
|
# 'btcusdt.binance',
|
||||||
|
# 'xbtusd.kraken',
|
||||||
|
|
||||||
|
'btcusdt.spot.binance',
|
||||||
|
'xbtusd.spot.kraken',
|
||||||
|
}, False),
|
||||||
],
|
],
|
||||||
ids=lambda param: f'quotes={param[0]}@fqmes={param[1]}',
|
ids=lambda param: f'quotes={param[0]}@fqmes={param[1]}',
|
||||||
)
|
)
|
||||||
|
|
@ -48,12 +70,17 @@ def test_multi_fqsn_feed(
|
||||||
|
|
||||||
if (
|
if (
|
||||||
ci_env
|
ci_env
|
||||||
and not run_in_ci
|
and
|
||||||
|
not run_in_ci
|
||||||
):
|
):
|
||||||
pytest.skip('Skipping CI disabled test due to feed restrictions')
|
pytest.skip(
|
||||||
|
'CI-disabled-test due to live-feed restrictions'
|
||||||
|
)
|
||||||
|
|
||||||
brokers = set()
|
brokers = set()
|
||||||
for fqme in fqmes:
|
for fqme in fqmes:
|
||||||
|
# ?TODO, add this unpack + normalize check to a symbology
|
||||||
|
# helper fn?
|
||||||
brokername, *_ = unpack_fqme(fqme)
|
brokername, *_ = unpack_fqme(fqme)
|
||||||
brokers.add(brokername)
|
brokers.add(brokername)
|
||||||
|
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue