From 9af6adc181971cd9139cf080cf42dac9460e9d3c Mon Sep 17 00:00:00 2001
From: goodboy <goodboy_foss@protonmail.com>
Date: Fri, 10 Apr 2026 16:20:01 -0400
Subject: [PATCH] Fix runtime kwarg leaking in `tractor_test`
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The `functools` rewrite forwarded all `kwargs`
through `_main(**kwargs)` to `wrapped(**kwargs)`
unchanged — the Windows `start_method` default
could leak to test fns that don't declare it.
The pre-wrapt code guarded against this with
named wrapper params.

Extract runtime settings (`reg_addr`, `loglevel`,
`debug_mode`, `start_method`) as closure locals
in `wrapper`; `_main` uses them directly for
`open_root_actor()` while `kwargs` passes to
`wrapped()` unmodified.

Review: PR #439 (Copilot)
https://github.com/goodboy/tractor/pull/439#pullrequestreview-4091005202

(this patch was generated in some part by [`claude-code`][claude-code-gh])
[claude-code-gh]: https://github.com/anthropics/claude-code
---
 tractor/_testing/pytest.py | 29 +++++++++++++++++------------
 1 file changed, 17 insertions(+), 12 deletions(-)

diff --git a/tractor/_testing/pytest.py b/tractor/_testing/pytest.py
index 26cbc68b..f843fb4c 100644
--- a/tractor/_testing/pytest.py
+++ b/tractor/_testing/pytest.py
@@ -127,38 +127,43 @@ def tractor_test(
             if kw in inspect.signature(wrapped).parameters:
                 assert kw in kwargs
 
+        # Extract runtime settings as locals for
+        # `open_root_actor()`; these must NOT leak into
+        # `kwargs` when the test fn doesn't declare them
+        # (the original pre-wrapt code had the same guard).
+        reg_addr = kwargs.get('reg_addr')
+        loglevel = kwargs.get('loglevel')
+        debug_mode = kwargs.get('debug_mode', False)
         start_method = kwargs.get('start_method')
         if platform.system() == 'Windows':
             if start_method is None:
-                kwargs['start_method'] = 'trio'
+                start_method = 'trio'
             elif start_method != 'trio':
                 raise ValueError(
                     'ONLY the `start_method="trio"` is supported on Windows.'
                 )
 
-        # Open a root-actor, passing certain runtime-settings
-        # extracted from the fixture kwargs, then invoke the
-        # test-fn body as the root-most task.
+        # Open a root-actor, passing runtime-settings
+        # extracted above as closure locals, then invoke
+        # the test-fn body as the root-most task.
         #
-        # NOTE: we use `kwargs.get()` (not named params) so that
-        # the fixture values remain in `kwargs` and are forwarded
-        # to `wrapped()` — the test fn may declare the same
-        # fixtures in its own signature.
+        # NOTE: `kwargs` is forwarded as-is to
+        # `wrapped()` — it only contains what pytest
+        # injected based on the test fn's signature.
         async def _main(**kwargs):
             __tracebackhide__: bool = hide_tb
 
-            reg_addr = kwargs.get('reg_addr')
             with trio.fail_after(timeout):
                 async with tractor.open_root_actor(
                     registry_addrs=(
                         [reg_addr] if reg_addr else None
                     ),
-                    loglevel=kwargs.get('loglevel'),
-                    start_method=kwargs.get('start_method'),
+                    loglevel=loglevel,
+                    start_method=start_method,
 
                     # TODO: only enable when pytest is passed
                     # --pdb
-                    debug_mode=kwargs.get('debug_mode', False),
+                    debug_mode=debug_mode,
 
                 ):
                     # invoke test-fn body IN THIS task